[Android] Handle different phones using different layouts for PreferenceFragment

chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java
index 8200b851289d31dac99eb75d16aced53220f5196..cb1e96720ba25eb366b7bda10b364e41f05794d1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java
@@ -6,7 +6,9 @@ package org.chromium.chrome.browser.preferences;
 
 import android.os.Bundle;
 import android.preference.PreferenceFragment;
-import android.widget.LinearLayout.LayoutParams;
+import android.view.ViewGroup.LayoutParams;
+import android.widget.FrameLayout;
+import android.widget.LinearLayout;
 import android.widget.ListView;
 
 import org.chromium.base.VisibleForTesting;
@@ -48,9 +50,12 @@ public class SearchEnginePreference extends PreferenceFragment {
         mListView = (ListView) getView().findViewById(android.R.id.list);
         int marginTop = getActivity().getResources().getDimensionPixelSize(
                 R.dimen.search_engine_list_margin_top);
-        LayoutParams layoutParams =
-                new LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT);
-        layoutParams.setMargins(0, marginTop, 0, 0);
+        LayoutParams layoutParams = mListView.getLayoutParams();
+        if (layoutParams instanceof FrameLayout.LayoutParams) {
+            ((FrameLayout.LayoutParams) layoutParams).setMargins(0, marginTop, 0, 0);

[gone, 2016/12/02 22:39:55]

Don't need to do this.  Both FrameLayout.LayoutParams and
LinearLayout.LayoutParams inherit from MarginLayoutParams:

https://developer.android.com/reference/android/view/ViewGroup.MarginLayoutPa...

[ltian, 2016/12/02 23:09:04]

Done.

+        } else {
+            ((LinearLayout.LayoutParams) layoutParams).setMargins(0, marginTop, 0, 0);
+        }
         mListView.setLayoutParams(layoutParams);
         mListView.setAdapter(mSearchEngineAdapter);
         mListView.setDivider(null);