Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2542943002: Generalized fix for serialization error/reset issues (Closed)

Created:
4 years ago by David Tseng
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge to m56: Generalized fix for serialization error/reset issues Whenever we see an AX tree fail to unserialize, request it be reset on the source end. TEST=in hotrod, repeatedly toggle on/off ChromeVox. Verify that we re-populate the tree when we get any events (e.g. focus). BUG=667819 TBR=dtseng@chromium.org Review-Url: https://codereview.chromium.org/2522033002 Cr-Commit-Position: refs/heads/master@{#433985} (cherry picked from commit 38c63d7344c76d9fa58c84db6112daebbfefd3ab) Committed: https://chromium.googlesource.com/chromium/src/+/a316708a12944f6222b0bba88dfddc767ffe893f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M chrome/common/extensions/api/automation_internal.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/automation_internal_custom_bindings.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/renderer/resources/extensions/automation_custom_bindings.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
David Tseng
4 years ago (2016-12-01 17:19:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a316708a12944f6222b0bba88dfddc767ffe893f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698