Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 2542933002: Remove obsolete keywords table migrating function (Closed)

Created:
4 years ago by Sunny
Modified:
4 years ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete keywords table migrating function Since the function KeywordTable::MigrateKeywordsTableForVersion45 is not used in codebase, it's safe to remove it. R=pkasting@chromium.org BUG=665018 Committed: https://crrev.com/62ef852f1de25d4ba2d877342791fb860479effd Cr-Commit-Position: refs/heads/master@{#436188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -88 lines) Patch
M components/search_engines/keyword_table.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/search_engines/keyword_table.cc View 1 chunk +0 lines, -84 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sunny
4 years ago (2016-12-03 10:21:35 UTC) #1
Peter Kasting
LGTM
4 years ago (2016-12-03 23:19:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542933002/1
4 years ago (2016-12-04 05:04:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-04 05:46:33 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-04 05:49:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62ef852f1de25d4ba2d877342791fb860479effd
Cr-Commit-Position: refs/heads/master@{#436188}

Powered by Google App Engine
This is Rietveld 408576698