Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4428)

Unified Diff: chrome/browser/android/compositor/scene_layer/toolbar_scene_layer.cc

Issue 2542883004: Bottom browser controls position based on window height (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/compositor/scene_layer/toolbar_scene_layer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/compositor/scene_layer/toolbar_scene_layer.cc
diff --git a/chrome/browser/android/compositor/scene_layer/toolbar_scene_layer.cc b/chrome/browser/android/compositor/scene_layer/toolbar_scene_layer.cc
index 1f0c80650db6f1b8ad7130eb340e5d31359756d7..0ef559db5eae7f3023df0f52742d3ac79109bb60 100644
--- a/chrome/browser/android/compositor/scene_layer/toolbar_scene_layer.cc
+++ b/chrome/browser/android/compositor/scene_layer/toolbar_scene_layer.cc
@@ -38,7 +38,7 @@ void ToolbarSceneLayer::UpdateToolbarLayer(
jint toolbar_background_color,
jint url_bar_resource_id,
jfloat url_bar_alpha,
- jfloat top_offset,
+ jfloat y_offset,
jfloat view_height,
bool visible,
bool show_shadow,
@@ -54,10 +54,9 @@ void ToolbarSceneLayer::UpdateToolbarLayer(
toolbar_layer_->layer()->SetHideLayerAndSubtree(!visible);
if (visible) {
- toolbar_layer_->layer()->SetPosition(gfx::PointF(0, top_offset));
toolbar_layer_->PushResource(toolbar_resource_id, toolbar_background_color,
false, SK_ColorWHITE, url_bar_resource_id,
- url_bar_alpha, view_height, false,
+ url_bar_alpha, view_height, y_offset, false,
!show_shadow, browser_controls_at_bottom);
}
}
« no previous file with comments | « chrome/browser/android/compositor/scene_layer/toolbar_scene_layer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698