Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: chrome/browser/android/compositor/layer/tab_layer.cc

Issue 2542883004: Bottom browser controls position based on window height (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/compositor/layer/tab_layer.cc
diff --git a/chrome/browser/android/compositor/layer/tab_layer.cc b/chrome/browser/android/compositor/layer/tab_layer.cc
index 578a0b83a22f144aa32866b15be71929fc3d659a..b3c94641d6588bb8a9c7b8e63965a910e318c29e 100644
--- a/chrome/browser/android/compositor/layer/tab_layer.cc
+++ b/chrome/browser/android/compositor/layer/tab_layer.cc
@@ -235,13 +235,16 @@ void TabLayer::SetProperties(int id,
toolbar_textbox_resource_id,
toolbar_textbox_alpha,
view_height,
+ // TODO(mdjones): Feels odd to pass 0 here when
+ // we have access to toolbar_y_offset.
+ 0,
false,
false,
browser_controls_at_bottom);
toolbar_layer_->UpdateProgressBar(0, 0, 0, 0, 0, 0, 0, 0, 0, 0);
float toolbar_impact_height = 0;
- if (show_toolbar && !back_visible)
+ if (show_toolbar && !back_visible && !browser_controls_at_bottom)
toolbar_impact_height = toolbar_layer_->layer()->bounds().height();
//----------------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698