Compute exported top-level declarations.

Compute exported top-level declarations.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/038cd323265758451fda23c9a3923596e6c4b1e1

[Brian Wilkerson, 2016-12-01 21:07:47]

lgtm

https://codereview.chromium.org/2542883003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right):

https://codereview.chromium.org/2542883003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_state.dart:152: declarations[t.name] =
t;
I think we need to test for private names both here and on line 156.

[Paul Berry, 2016-12-01 21:16:10]

https://codereview.chromium.org/2542883003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right):

https://codereview.chromium.org/2542883003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_state.dart:138:
List<TopLevelDeclaration> get exportTopLevelDeclarations {
This sounds like the name of a method with takes some top level declarations and
exports them.  Consider renaming to "exportedTopLevelDeclarations".

https://codereview.chromium.org/2542883003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_state.dart:147:
List<TopLevelDeclaration> computeExported(FileState library) {
I think there's a bug.  Consider the following:

a.dart:
export 'b.dart' show Foo;
export 'c.dart' show Bar;

b.dart:
export 'd.dart';

c.dart:
export 'd.dart';

d.dart:
class Foo {}
class Bar {}

The first time we call computeExported() for d.dart, we're calling in the
context of b.dart, so we'll filter out Bar and only find Foo.  The second time
we call computeExported() for d.dart, we're calling in the context of c.dart. 
But since seenLibraries already contains d.dart at that point, we'll return an
empty list.  So Bar will get missed.

[scheglov, 2016-12-01 21:39:56]

PTAL

https://codereview.chromium.org/2542883003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right):

https://codereview.chromium.org/2542883003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_state.dart:138:
List<TopLevelDeclaration> get exportTopLevelDeclarations {
On 2016/12/01 21:16:10, Paul Berry wrote:
> This sounds like the name of a method with takes some top level declarations
and
> exports them.  Consider renaming to "exportedTopLevelDeclarations".

Done.

https://codereview.chromium.org/2542883003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_state.dart:147:
List<TopLevelDeclaration> computeExported(FileState library) {
On 2016/12/01 21:16:10, Paul Berry wrote:
> I think there's a bug.  Consider the following:
> 
> a.dart:
> export 'b.dart' show Foo;
> export 'c.dart' show Bar;
> 
> b.dart:
> export 'd.dart';
> 
> c.dart:
> export 'd.dart';
> 
> d.dart:
> class Foo {}
> class Bar {}
> 
> The first time we call computeExported() for d.dart, we're calling in the
> context of b.dart, so we'll filter out Bar and only find Foo.  The second time
> we call computeExported() for d.dart, we're calling in the context of c.dart. 
> But since seenLibraries already contains d.dart at that point, we'll return an
> empty list.  So Bar will get missed.

You're right.
Fixed.

https://codereview.chromium.org/2542883003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_state.dart:152: declarations[t.name] =
t;
On 2016/12/01 21:07:47, Brian Wilkerson wrote:
> I think we need to test for private names both here and on line 156.

Done.

[Paul Berry, 2016-12-01 21:44:04]

lgtm

[Brian Wilkerson, 2016-12-01 21:44:15]

lgtm

[scheglov, 2016-12-01 21:49:05]

Description was changed from

==========
Compute exported top-level declarations.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Compute exported top-level declarations.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/038cd323265758451fda23c9a3923596e6c4b1e1
==========

[scheglov, 2016-12-01 21:49:07]

Committed patchset #2 (id:20001) manually as
038cd323265758451fda23c9a3923596e6c4b1e1 (presubmit successful).