Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2542883002: Merge 2924: Avoid updateStyleAndLayoutTree in determineAccessibilityRole (Closed)

Created:
4 years ago by kojii
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge 2924: Avoid updateStyleAndLayoutTree in determineAccessibilityRole This patch avoids updating layout tree in AXNodeObject::determineAccessibilityRole(). Element::isFocusable() requires styles to be updated. However, when layout code calls determineAccessibilityRole(), updating layout tree should be avoided since it may destroy the calling object. This patch replaces it to supportsFocus(), since the main purpose is to give elements with tabIndex explicitly set get some role. This is a speculative fix. BUG=590369, 647602, 665168 Review-Url: https://codereview.chromium.org/2532023002 Cr-Commit-Position: refs/heads/master@{#435009} (cherry picked from commit 338b38e06760302a8010bfea008865f55db4db0c) Committed: https://chromium.googlesource.com/chromium/src/+/13ae3f245af2124718f024ae13f328c27c618f09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kojii
4 years ago (2016-12-01 08:31:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
13ae3f245af2124718f024ae13f328c27c618f09.

Powered by Google App Engine
This is Rietveld 408576698