content/browser/devtools/protocol/tracing_handler_unittest.cc - Issue 2542853002: [tracing] Introduce config to setup memory-infra peak detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/tracing_handler_unittest.cc

Issue 2542853002: [tracing] Introduce config to setup memory-infra peak detection (Closed)

Patch Set: fix devtools test. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/devtools/protocol/tracing_handler_unittest.cc

diff --git a/content/browser/devtools/protocol/tracing_handler_unittest.cc b/content/browser/devtools/protocol/tracing_handler_unittest.cc

index 8ca2dee070b027c045b98e4f42f2e2729ce5e570..429c4dfb2b70be86db2558e35d6195885b50f963 100644

--- a/content/browser/devtools/protocol/tracing_handler_unittest.cc

+++ b/content/browser/devtools/protocol/tracing_handler_unittest.cc

@@ -25,8 +25,16 @@ const char kCustomTraceConfigString[] =

"\"memory_dump_config\":{"

"\"allowed_dump_modes\":[\"background\",\"light\",\"detailed\"],"

"\"triggers\":["

- "{\"mode\":\"light\",\"periodic_interval_ms\":50},"

- "{\"mode\":\"detailed\",\"periodic_interval_ms\":1000}"

+ "{"

+ "\"min_time_between_dumps_ms\":50,"

+ "\"mode\":\"light\","

+ "\"type\":\"periodic_interval\""

+ "},"

+ "{"

+ "\"min_time_between_dumps_ms\":1000,"

+ "\"mode\":\"detailed\","

+ "\"type\":\"periodic_interval\""

+ "}"

"]"

"},"

"\"record_mode\":\"record-continuously\","

@@ -43,10 +51,18 @@ const char kCustomTraceConfigStringDevToolsStyle[] =

"\"disabled-by-default-cc\","

"\"disabled-by-default-memory-infra\"],"

"\"memoryDumpConfig\":{"

- "\"allowed_dump_modes\":[\"background\",\"light\",\"detailed\"],"

+ "\"allowedDumpModes\":[\"background\",\"light\",\"detailed\"],"

"\"triggers\":["

- "{\"mode\":\"light\",\"periodicIntervalMs\":50},"

- "{\"mode\":\"detailed\",\"periodicIntervalMs\":1000}"

+ "{"

+ "\"minTimeBetweenDumpsMs\":50,"

+ "\"mode\":\"light\","

+ "\"type\":\"periodic_interval\""

+ "},"

+ "{"

+ "\"minTimeBetweenDumpsMs\":1000,"

+ "\"mode\":\"detailed\","

+ "\"type\":\"periodic_interval\""

+ "}"

"]"

"},"

"\"recordMode\":\"recordContinuously\","

« base/trace_event/trace_config.cc ('K') | « base/trace_event/trace_config_unittest.cc ('k') | no next file » | no next file with comments »