Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 2542843009: Avoid gurl -> origin -> gurl conversion in AddCookieHeaderAndStart (Closed)

Created:
4 years ago by Charlie Harrison
Modified:
4 years ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid gurl -> origin -> gurl conversion in AddCookieHeaderAndStart SameDomainOrHost does not require Origins. In fact, we just convert the origins back to GURLs to do the check, which just looks at the host piece of the url. This conversion is not free in either direction, as we need to do allocations, copies, and in some cases, url-related policies (e.g. in constructing the underlying SchemeHostPort of Origin). BUG=664174 Committed: https://crrev.com/d5c68c496fa9111fb45e482d4feea0f1a2cdcb9e Cr-Commit-Position: refs/heads/master@{#436092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M net/url_request/url_request_http_job.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Charlie Harrison
mmenke@ PTAL (trivial)?
4 years ago (2016-12-02 22:03:30 UTC) #5
mmenke
On 2016/12/02 22:03:30, Charlie Harrison wrote: > mmenke@ PTAL (trivial)? LGTM
4 years ago (2016-12-02 22:17:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542843009/1
4 years ago (2016-12-02 22:28:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-03 00:15:57 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-03 00:20:20 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5c68c496fa9111fb45e482d4feea0f1a2cdcb9e
Cr-Commit-Position: refs/heads/master@{#436092}

Powered by Google App Engine
This is Rietveld 408576698