Changed EPointerEvents to an enum class and renamed its members to keywords

Changed EPointerEvents to an enum class and renamed its members to keywords

Changed EPointerEvents to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EPointerEvents to be generated in
ComputedStyleBase.

BUG=628043
Committed: https://crrev.com/7288d286aaf11b6c4a6da25b8dc6209f64908f97
Cr-Commit-Position: refs/heads/master@{#436232}

[napper, 2016-12-01 06:11:08]

The CQ bit was checked by napper@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 06:11:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 07:25:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 07:25:10]

Dry run: This issue passed the CQ dry run.

[napper, 2016-12-01 19:56:03]

Description was changed from

==========
Changed EPointerEvents to an enum class and renamed its members to keywords

Changed EPointerEvents to an enum class and gave it an unsigned
underlying type. Also renamed its members to match its keywords from
CSSValueKeywords.in.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EPointerEvents to be generated in
ComputedStyleBase.

BUG=628043
==========

to

==========
Changed EPointerEvents to an enum class and renamed its members to keywords

Changed EPointerEvents to an enum class and gave it an unsigned
underlying type. Also renamed its members to match its keywords from
CSSValueKeywords.in.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EPointerEvents to be generated in
ComputedStyleBase.

BUG=628043
==========

[napper, 2016-12-01 19:56:03]

napper@chromium.org changed reviewers:
+ sashab@chromium.org

[sashab, 2016-12-04 22:43:12]

Nice work, but this is only the first part of your patch description:

Changed EPointerEvents to an enum class and gave it an unsigned underlying type.
-- Done

Also renamed its members to match its keywords from CSSValueKeywords.in.
-- Not done

Happy to let you land this if you change the desc to say only the first part,
then do a second patch to rename the members. I have done this before :)
Alternatively they can be both in the same patch, your choice :)

[napper, 2016-12-04 22:47:35]

Description was changed from

==========
Changed EPointerEvents to an enum class and renamed its members to keywords

Changed EPointerEvents to an enum class and gave it an unsigned
underlying type. Also renamed its members to match its keywords from
CSSValueKeywords.in.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EPointerEvents to be generated in
ComputedStyleBase.

BUG=628043
==========

to

==========
Changed EPointerEvents to an enum class and renamed its members to keywords

Changed EPointerEvents to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EPointerEvents to be generated in
ComputedStyleBase.

BUG=628043
==========

[napper, 2016-12-04 22:48:12]

Sorry, missed that. I will rename the members to match in a following CL.

[sashab, 2016-12-04 23:03:51]

lgtm

[napper, 2016-12-04 23:07:17]

The CQ bit was checked by napper@chromium.org

[commit-bot: I haz the power, 2016-12-04 23:07:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-04 23:13:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-04 23:13:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sashab, 2016-12-04 23:14:54]

You'll need someone from the OWNERS file in core/svg and core/web :)

[sashab, 2016-12-04 23:15:42]

On 2016/12/04 at 23:14:54, sashab wrote:
> You'll need someone from the OWNERS file in core/svg and core/web :)

Oops sorry I meant just Source/web, I'm OWNERS for core/* :)

[napper, 2016-12-04 23:30:41]

napper@chromium.org changed reviewers:
+ dcheng@chromium.org

[napper, 2016-12-04 23:31:03]

dcheng@ please RS web/

[dcheng, 2016-12-05 02:23:48]

lgtm

[napper, 2016-12-05 02:54:03]

The CQ bit was checked by napper@chromium.org

[commit-bot: I haz the power, 2016-12-05 02:54:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 04:35:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480906443906160, "parent_rev":
"0e789d4ae6eeaedd7fb34e1e75a793f3dc52d194", "commit_rev":
"86ab2cb0553822427437f8fcd787b8844ead1986"}

[commit-bot: I haz the power, 2016-12-05 04:36:21]

Description was changed from

==========
Changed EPointerEvents to an enum class and renamed its members to keywords

Changed EPointerEvents to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EPointerEvents to be generated in
ComputedStyleBase.

BUG=628043
==========

to

==========
Changed EPointerEvents to an enum class and renamed its members to keywords

Changed EPointerEvents to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EPointerEvents to be generated in
ComputedStyleBase.

BUG=628043
==========

[commit-bot: I haz the power, 2016-12-05 04:36:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-05 04:38:01]

Description was changed from

==========
Changed EPointerEvents to an enum class and renamed its members to keywords

Changed EPointerEvents to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EPointerEvents to be generated in
ComputedStyleBase.

BUG=628043
==========

to

==========
Changed EPointerEvents to an enum class and renamed its members to keywords

Changed EPointerEvents to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EPointerEvents to be generated in
ComputedStyleBase.

BUG=628043

Committed: https://crrev.com/7288d286aaf11b6c4a6da25b8dc6209f64908f97
Cr-Commit-Position: refs/heads/master@{#436232}
==========

[commit-bot: I haz the power, 2016-12-05 04:38:02]

Patchset 1 (id:??) landed as
https://crrev.com/7288d286aaf11b6c4a6da25b8dc6209f64908f97
Cr-Commit-Position: refs/heads/master@{#436232}