Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2542813002: [TTS] Log diagnostic output log for Contextual Cards. (Closed)

Created:
4 years ago by Donn Denman
Modified:
4 years ago
Reviewers:
Theresa
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Log diagnostic output log for Contextual Cards. When Contextual Cards integration is enabled we now check for server diagnostic data in the response and output it to the log when on a debug build. BUG=644934 Committed: https://crrev.com/9984a7a17903296aa3063dcbc6892666464648bb Cr-Commit-Position: refs/heads/master@{#435662}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M chrome/browser/android/contextualsearch/contextual_search_delegate.cc View 1 chunk +9 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Donn Denman
Theresa, PTAL.
4 years ago (2016-12-01 17:46:35 UTC) #2
Theresa
lgtm
4 years ago (2016-12-01 17:53:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542813002/1
4 years ago (2016-12-01 18:24:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 18:56:45 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-01 19:00:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9984a7a17903296aa3063dcbc6892666464648bb
Cr-Commit-Position: refs/heads/master@{#435662}

Powered by Google App Engine
This is Rietveld 408576698