Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2542803002: [Mac] Fullscreen Toolbar Animation Fix (Closed)

Created:
4 years ago by spqchan
Modified:
4 years ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fullscreen Toolbar Animation Fix - Fixed the animation so that the toolbar animates in when it's locked by an object BUG=659752 Committed: https://crrev.com/9d140c92c5c769bc3e11c642b0de2d69c4a9f3a3 Cr-Commit-Position: refs/heads/master@{#435659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
spqchan
PTAL
4 years ago (2016-12-01 18:02:32 UTC) #6
Robert Sesek
lgtm
4 years ago (2016-12-01 18:30:01 UTC) #7
spqchan
On 2016/12/01 18:30:01, Robert Sesek wrote: > lgtm thanks!
4 years ago (2016-12-01 18:39:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542803002/1
4 years ago (2016-12-01 18:39:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 18:44:27 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-01 18:47:49 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d140c92c5c769bc3e11c642b0de2d69c4a9f3a3
Cr-Commit-Position: refs/heads/master@{#435659}

Powered by Google App Engine
This is Rietveld 408576698