Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 2542783002: dart2js-kernel: Handle some more 'is' cases (Closed)

Created:
4 years ago by sra1
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js-kernel: Handle some more 'is' cases Adds type variables and function types. Still missing parameterized interface types. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/f62009a3aa3419afec7ccfe57ccb0d8721eb6228

Patch Set 1 #

Patch Set 2 : dartfmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -7 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 3 chunks +43 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
+ 2742 | - 1924
4 years ago (2016-12-01 00:13:56 UTC) #2
Siggi Cherem (dart-lang)
lgtm!
4 years ago (2016-12-01 16:11:13 UTC) #3
sra1
4 years ago (2016-12-01 17:28:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f62009a3aa3419afec7ccfe57ccb0d8721eb6228 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698