Fix initial kerning when there is a horzscale set

Fix initial kerning when there is a horzscale set

Reasoning: the pTextAdvanceX in CPDF_TextObject::CalcPositionData is
being multiplied by horz_scale in CPDF_TextObject::CalcPositionData.
Then, m_pCurStates->m_TextX is updated by this amount. So multiply by
the scale also when updating with initial and final kerning and when
nsegs = 0.

BUG=528103
Committed: https://pdfium.googlesource.com/pdfium/+/c62980ec7539fa5ae2065ba5f287aada3a814173

[npm, 2016-11-30 22:43:46]

Description was changed from

==========
Fix initial kerning when there is a horzscale set

Reasoning: the pTextAdvanceX in CPDF_TextObject::CalcPositionData is
being multiplied by horz_scale in CPDF_TextObject::CalcPositionData.
Then, m_pCurStates->m_TextX is updated by this amount. So multiply by
the scale also when updating with initial and final kerning and when
nsegs = 0.

BUG=528103
==========

to

==========
Fix initial kerning when there is a horzscale set

Reasoning: the pTextAdvanceX in CPDF_TextObject::CalcPositionData is
being multiplied by horz_scale in CPDF_TextObject::CalcPositionData.
Then, m_pCurStates->m_TextX is updated by this amount. So multiply by
the scale also when updating with initial and final kerning and when
nsegs = 0.

BUG=528103
==========

[npm, 2016-11-30 22:43:46]

npm@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[npm, 2016-11-30 22:43:52]

ptal

[Tom Sepez, 2016-11-30 23:06:01]

LGTM, but will this cause our reference test output .pngs to diff?

[npm, 2016-11-30 23:07:18]

On 2016/11/30 23:06:01, Tom Sepez wrote:
> LGTM, but will this cause our reference test output .pngs to diff?

Corpus tests? I think no. Let me Dry run.

[npm, 2016-11-30 23:07:24]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 23:07:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-11-30 23:07:58]

On 2016/11/30 23:07:18, npm wrote:
> On 2016/11/30 23:06:01, Tom Sepez wrote:
> > LGTM, but will this cause our reference test output .pngs to diff?
> 
> Corpus tests? I think no. Let me Dry run.

Should probably add a corpus test for this if no

[commit-bot: I haz the power, 2016-11-30 23:16:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 23:16:16]

Dry run: This issue passed the CQ dry run.

[npm, 2016-11-30 23:16:33]

On 2016/11/30 23:07:58, npm wrote:
> On 2016/11/30 23:07:18, npm wrote:
> > On 2016/11/30 23:06:01, Tom Sepez wrote:
> > > LGTM, but will this cause our reference test output .pngs to diff?
> > 
> > Corpus tests? I think no. Let me Dry run.
> 
> Should probably add a corpus test for this if no

Indeed we have no tests for this. Surprise surprise

[npm, 2016-11-30 23:22:53]

The CQ bit was checked by npm@chromium.org

[commit-bot: I haz the power, 2016-11-30 23:22:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 23:23:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480548173490520, "parent_rev":
"345d489b70a8e057587512524e69bd5692e2e14b", "commit_rev":
"c62980ec7539fa5ae2065ba5f287aada3a814173"}

[commit-bot: I haz the power, 2016-11-30 23:23:14]

Description was changed from

==========
Fix initial kerning when there is a horzscale set

Reasoning: the pTextAdvanceX in CPDF_TextObject::CalcPositionData is
being multiplied by horz_scale in CPDF_TextObject::CalcPositionData.
Then, m_pCurStates->m_TextX is updated by this amount. So multiply by
the scale also when updating with initial and final kerning and when
nsegs = 0.

BUG=528103
==========

to

==========
Fix initial kerning when there is a horzscale set

Reasoning: the pTextAdvanceX in CPDF_TextObject::CalcPositionData is
being multiplied by horz_scale in CPDF_TextObject::CalcPositionData.
Then, m_pCurStates->m_TextX is updated by this amount. So multiply by
the scale also when updating with initial and final kerning and when
nsegs = 0.

BUG=528103

Committed:
https://pdfium.googlesource.com/pdfium/+/c62980ec7539fa5ae2065ba5f287aada3a81...
==========

[commit-bot: I haz the power, 2016-11-30 23:23:15]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/c62980ec7539fa5ae2065ba5f287aada3a81...