Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2542723002: Margins that start at fragmentainer boundaries should be collapsed away. (Closed)

Created:
4 years ago by mstensho (USE GERRIT)
Modified:
4 years ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Margins that start at fragmentainer boundaries should be collapsed away. This only applies if the fragmentainer break is unforced. If it's forced, the margin is to be preserved. See https://drafts.csswg.org/css-break/#break-margins Get rid of LayoutBlock::nextPageLogicalTop(), since nobody calls it anymore. BUG=440362 Committed: https://crrev.com/506506eac78a8106c4e92866a59b8c724ddc8b88 Cr-Commit-Position: refs/heads/master@{#435917}

Patch Set 1 #

Patch Set 2 : rebaseline #

Patch Set 3 : Revert rebaseline. No need for this if we back out some unnecessary and possibly harmful code chang… #

Patch Set 4 : Back out an unnecessary and potentially harmful change. #

Messages

Total messages: 20 (14 generated)
mstensho (USE GERRIT)
Revert rebaseline. No need for this if we back out some unnecessary and possibly harmful ...
4 years ago (2016-12-01 08:55:12 UTC) #7
mstensho (USE GERRIT)
4 years ago (2016-12-01 09:00:07 UTC) #11
eae
LGTM
4 years ago (2016-12-02 09:54:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542723002/60001
4 years ago (2016-12-02 09:58:22 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-02 11:50:58 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-02 11:52:35 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/506506eac78a8106c4e92866a59b8c724ddc8b88
Cr-Commit-Position: refs/heads/master@{#435917}

Powered by Google App Engine
This is Rietveld 408576698