Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2542673004: Improve early return in CGifLZWDecoder::Decode (Closed)

Created:
4 years ago by npm
Modified:
4 years ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Improve early return in CGifLZWDecoder::Decode |code_size_cur| could be larger than |code_size|, so |code| could be larger than |code_end|. If this happens, early return, since the Decode has failed. BUG=659417 Committed: https://pdfium.googlesource.com/pdfium/+/9be9c3486688b84c723f41c85327abec238f15f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/fxcodec/lgif/fx_gif.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
npm
ptal
4 years ago (2016-12-01 16:27:58 UTC) #3
Tom Sepez
LGTM, I guess adding test would be hard?
4 years ago (2016-12-01 17:56:40 UTC) #4
npm
On 2016/12/01 17:56:40, Tom Sepez wrote: > LGTM, I guess adding test would be hard? ...
4 years ago (2016-12-01 18:06:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542673004/1
4 years ago (2016-12-01 18:21:58 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-01 18:36:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/9be9c3486688b84c723f41c85327abec238f...

Powered by Google App Engine
This is Rietveld 408576698