Run the dEQP GLES 3.1 tests on Windows and Linux NVIDIA OpenGL.

Run the dEQP GLES 3.1 tests on Windows and Linux NVIDIA OpenGL.

BUG=angleproject:1442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/366f3af1194430904d8d3587598f7d02213446bd
Cr-Commit-Position: refs/heads/master@{#435650}

[Geoff Lang, 2016-11-30 17:01:42]

Description was changed from

==========
Run the dEQP GLES 3.1 tests on Windows and Linux NVIDIA OpenGL.

BUG=angleproject:1442
==========

to

==========
Run the dEQP GLES 3.1 tests on Windows and Linux NVIDIA OpenGL.

BUG=angleproject:1442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Geoff Lang, 2016-11-30 17:03:02]

Description was changed from

==========
Run the dEQP GLES 3.1 tests on Windows and Linux NVIDIA OpenGL.

BUG=angleproject:1442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Run the dEQP GLES 3.1 tests on Windows and Linux NVIDIA OpenGL.

BUG=angleproject:1442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Geoff Lang, 2016-11-30 17:03:19]

Description was changed from

==========
Run the dEQP GLES 3.1 tests on Windows and Linux NVIDIA OpenGL.

BUG=angleproject:1442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Run the dEQP GLES 3.1 tests on Windows and Linux NVIDIA OpenGL.

BUG=angleproject:1442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Geoff Lang, 2016-11-30 17:03:31]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 17:04:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2016-11-30 18:06:41]

Description was changed from

==========
Run the dEQP GLES 3.1 tests on Windows and Linux NVIDIA OpenGL.

BUG=angleproject:1442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Run the dEQP GLES 3.1 tests on Windows and Linux NVIDIA OpenGL.

BUG=angleproject:1442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Geoff Lang, 2016-11-30 18:06:47]

The CQ bit was unchecked by geofflang@chromium.org

[Geoff Lang, 2016-11-30 18:07:54]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 18:08:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2016-11-30 18:31:34]

geofflang@chromium.org changed reviewers:
+ kbr@chromium.org

[Geoff Lang, 2016-11-30 18:31:34]

PTAL

[Jamie Madill, 2016-11-30 18:38:37]

jmadill@chromium.org changed reviewers:
+ jmadill@chromium.org

[Jamie Madill, 2016-11-30 18:38:37]

https://codereview.chromium.org/2542653002/diff/1/content/test/gpu/generate_b...
File content/test/gpu/generate_buildbot_json.py (right):

https://codereview.chromium.org/2542653002/diff/1/content/test/gpu/generate_b...
content/test/gpu/generate_buildbot_json.py:866: 'shards': 4,
There are more tests in the gles31 test set than gles3, but they run super
quickly now because of so many skipped tests due to missing features. The gles3
tests use 12 shards -- please add a TODO here to increase the shard count as the
tests become slower with more tests enabled.

[commit-bot: I haz the power, 2016-11-30 19:44:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 19:44:57]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2016-11-30 21:45:51]

lgtm with Jamie's concern addressed.

[Jamie Madill, 2016-12-01 14:54:43]

One additional thing Geoff: you'll need to pass the command line flags to
angle_deqp_gtest.cpp in angle_deqp_tests_main.cc

https://cs.chromium.org/chromium/src/gpu/angle_deqp_tests_main.cc

I don't see that they have been added yet.

[Geoff Lang, 2016-12-01 16:22:29]

Updated the main file to pass the args.

https://codereview.chromium.org/2542653002/diff/1/content/test/gpu/generate_b...
File content/test/gpu/generate_buildbot_json.py (right):

https://codereview.chromium.org/2542653002/diff/1/content/test/gpu/generate_b...
content/test/gpu/generate_buildbot_json.py:866: 'shards': 4,
On 2016/11/30 18:38:37, Jamie Madill wrote:
> There are more tests in the gles31 test set than gles3, but they run super
> quickly now because of so many skipped tests due to missing features. The
gles3
> tests use 12 shards -- please add a TODO here to increase the shard count as
the
> tests become slower with more tests enabled.

Done.

[Jamie Madill, 2016-12-01 16:34:35]

lgtm! I like that you didn't import the header.

[Geoff Lang, 2016-12-01 16:35:56]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 16:36:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 17:52:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 17:52:02]

Dry run: This issue passed the CQ dry run.

[Geoff Lang, 2016-12-01 18:03:04]

The CQ bit was checked by geofflang@chromium.org

[Geoff Lang, 2016-12-01 18:03:04]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2542653002/#ps20001
(title: "Forward args to the dEQP runner.")

[commit-bot: I haz the power, 2016-12-01 18:03:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 18:08:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480615384300650,
"parent_rev": "152179aa181ba20d3da8a1825a15dd7fe17d964d", "commit_rev":
"1d51aaf9880287bff5a0ba38b6d39079c851ec89"}

[commit-bot: I haz the power, 2016-12-01 18:08:41]

Description was changed from

==========
Run the dEQP GLES 3.1 tests on Windows and Linux NVIDIA OpenGL.

BUG=angleproject:1442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Run the dEQP GLES 3.1 tests on Windows and Linux NVIDIA OpenGL.

BUG=angleproject:1442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-12-01 18:08:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-01 18:10:33]

Description was changed from

==========
Run the dEQP GLES 3.1 tests on Windows and Linux NVIDIA OpenGL.

BUG=angleproject:1442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Run the dEQP GLES 3.1 tests on Windows and Linux NVIDIA OpenGL.

BUG=angleproject:1442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/366f3af1194430904d8d3587598f7d02213446bd
Cr-Commit-Position: refs/heads/master@{#435650}
==========

[commit-bot: I haz the power, 2016-12-01 18:10:34]

Patchset 2 (id:??) landed as
https://crrev.com/366f3af1194430904d8d3587598f7d02213446bd
Cr-Commit-Position: refs/heads/master@{#435650}