Issue 254263004: Revert of Removed dependency on the UI from the NetworkPortalDetector.

Issue 254263004: Revert of Removed dependency on the UI from the NetworkPortalDetector. (Closed)

Created:
6 years, 7 months ago by ygorshenin1

Modified:
6 years, 7 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Removed dependency on the UI from the NetworkPortalDetector. (https://codereview.chromium.org/245113003/) Reason for revert: Causes crashes. Original issue's description: > Removed dependency on the UI from the NetworkPortalDetector. > > BUG=363776 > TEST=browser_tests:NetworkPortalDetectorImpl* > R=stevenjb@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267169 TBR=stevenjb@chromium.org NOTREECHECKS=true NOTRY=true BUG=363776 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267190

Patch Set 1 #

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -68 lines)			Patch
M	chrome/browser/chromeos/login/captive_portal_window_browsertest.cc	View	2 chunks	+3 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/login/screens/error_screen.h	View	4 chunks	+15 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/screens/error_screen.cc	View	3 chunks	+14 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/net/network_portal_detector.h	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/net/network_portal_detector.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/net/network_portal_detector_impl.h	View	4 chunks	+15 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/net/network_portal_detector_impl.cc	View	6 chunks	+39 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/net/network_portal_detector_strategy.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/net/network_portal_detector_test_impl.h	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	chrome/browser/chromeos/net/network_portal_detector_test_impl.cc	View	2 chunks	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ygorshenin1

Created Revert of Removed dependency on the UI from the NetworkPortalDetector.

6 years, 7 months ago (2014-04-30 12:00:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/254263004/1

6 years, 7 months ago (2014-04-30 12:00:37 UTC) #2

Message was sent while issue was closed.

Change committed as 267190

Expand Messages | Collapse Messages