Password bubble: ManagePasswordsIconView is now a BubbleIconView.

Password bubble: ManagePasswordsIconView is now a BubbleIconView.

This CL introduces a new browser command to open the Manage Passwords bubble,
and converts the ManagePasswordsIconView class into a subclass of
BubbleIconView, which uses the new command to control the bubble's state.
This allows us to more easily test the view and the UI controller, as each
object's job is now more clearly defined (and the view is now doing a good
deal less work), and to independently verify that the command is doing the
right thing.

After this CL, we'll (finally!) have something approaching reasonable test
coverage for the core of the views code.

----------------------------------------------------------------------------
This is a re-land of r266859, which was reverted due to LSAN errors. The
original review is https://codereview.chromium.org/246393004/
----------------------------------------------------------------------------

BUG=365678
TBR=vabr@chromium.org,pkasting@chromium.org,cpu@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267195

[Mike West, 2014-04-30 07:51:04]

Hi Vaclav! Would you mind reviewing the diff between this patch and the patch
which was reverted?
https://codereview.chromium.org/246393004/diff2/130001:150001/chrome/browser/...
is all that changed.

Thanks!

-mike

[vabr (Chromium), 2014-04-30 08:24:13]

https://codereview.chromium.org/254263002/diff/1/chrome/browser/ui/views/pass...
File chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc (right):

https://codereview.chromium.org/254263002/diff/1/chrome/browser/ui/views/pass...
chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc:163: // The
combobox doesn't take ownership of it's model. If we created a combobox
Hi Mike, please see my comment at:
https://codereview.chromium.org/246393004/diff/150001/chrome/browser/ui/views...

[Mike West, 2014-04-30 08:45:00]

Mind taking another look, Vaclav?

Thanks!

-mike

[vabr (Chromium), 2014-04-30 09:01:01]

LGTM,
Thanks Mike!
Vaclav

https://codereview.chromium.org/254263002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h (right):

https://codereview.chromium.org/254263002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h:115: // The
combobox doesn't take ownership of it's model. If we created a combobox
nit: it's -> its

[Mike West, 2014-04-30 09:34:42]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-04-30 09:34:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/254263002/20001

[commit-bot: I haz the power, 2014-04-30 09:53:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-30 09:53:34]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium

[Mike West, 2014-04-30 09:54:56]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-04-30 09:55:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/254263002/20001

[commit-bot: I haz the power, 2014-04-30 12:14:14]

Change committed as 267195

[eroman, 2014-04-30 17:07:12]

Reverted because of bot failure:

http://build.chromium.org/p/chromium.win/builders/Interactive%20Tests%20%28db...