Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2542613002: [GN] Fix generate Xcode project for macOS to work with Xcode 8. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] Fix generate Xcode project for macOS to work with Xcode 8. Overridding ARCHS prevents Xcode 8+ from running the compiled binary on macOS. In addition avoid hard-coding the version of the SDK to use (since we do not build with Xcode this value is unused) and instead mention that the version-less SDK. BUG=634501 Committed: https://crrev.com/5d7f4cee65382c428e9d08112354a8a9bd496aa9 Cr-Commit-Position: refs/heads/master@{#435483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -21 lines) Patch
M tools/gn/xcode_writer.cc View 2 chunks +1 line, -21 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years ago (2016-11-30 14:06:46 UTC) #3
Dirk Pranke
lgtm
4 years ago (2016-11-30 23:54:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542613002/1
4 years ago (2016-11-30 23:54:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 23:59:18 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-01 00:01:41 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d7f4cee65382c428e9d08112354a8a9bd496aa9
Cr-Commit-Position: refs/heads/master@{#435483}

Powered by Google App Engine
This is Rietveld 408576698