Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: components/autofill/core/browser/autofill_manager.cc

Issue 2542593003: HTTP Bad: Add a seperator between http warning message and other entries (Closed)
Patch Set: fix win trybots Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/browser/autofill_manager.h" 5 #include "components/autofill/core/browser/autofill_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 575 matching lines...) Expand 10 before | Expand all | Expand 10 after
586 // Autofill is disabled for a website. 586 // Autofill is disabled for a website.
587 Suggestion warning_suggestion(l10n_util::GetStringUTF16( 587 Suggestion warning_suggestion(l10n_util::GetStringUTF16(
588 IDS_AUTOFILL_WARNING_INSECURE_CONNECTION)); 588 IDS_AUTOFILL_WARNING_INSECURE_CONNECTION));
589 warning_suggestion.frontend_id = 589 warning_suggestion.frontend_id =
590 POPUP_ITEM_ID_INSECURE_CONTEXT_PAYMENT_DISABLED_MESSAGE; 590 POPUP_ITEM_ID_INSECURE_CONTEXT_PAYMENT_DISABLED_MESSAGE;
591 suggestions.assign(1, warning_suggestion); 591 suggestions.assign(1, warning_suggestion);
592 592
593 // On top of the explanation message, first show a "Payment not secure" 593 // On top of the explanation message, first show a "Payment not secure"
594 // message. 594 // message.
595 if (IsCreditCardAutofillHttpWarningEnabled()) { 595 if (IsCreditCardAutofillHttpWarningEnabled()) {
596 #if !defined(OS_ANDROID)
597 suggestions.insert(suggestions.begin(), Suggestion());
598 suggestions.front().frontend_id = POPUP_ITEM_ID_SEPARATOR;
599 #endif
596 suggestions.insert(suggestions.begin(), 600 suggestions.insert(suggestions.begin(),
597 CreateHttpWarningMessageSuggestionItem( 601 CreateHttpWarningMessageSuggestionItem(
598 form_structure->source_url())); 602 form_structure->source_url()));
599 } 603 }
600 } else { 604 } else {
601 bool section_is_autofilled = 605 bool section_is_autofilled =
602 SectionIsAutofilled(*form_structure, form, 606 SectionIsAutofilled(*form_structure, form,
603 autofill_field->section()); 607 autofill_field->section());
604 if (section_is_autofilled) { 608 if (section_is_autofilled) {
605 // If the relevant section is auto-filled and the renderer is querying 609 // If the relevant section is auto-filled and the renderer is querying
(...skipping 1512 matching lines...) Expand 10 before | Expand all | Expand 10 after
2118 if (i > 0) 2122 if (i > 0)
2119 fputs("Next oldest form:\n", file); 2123 fputs("Next oldest form:\n", file);
2120 } 2124 }
2121 fputs("\n", file); 2125 fputs("\n", file);
2122 2126
2123 fclose(file); 2127 fclose(file);
2124 } 2128 }
2125 #endif // ENABLE_FORM_DEBUG_DUMP 2129 #endif // ENABLE_FORM_DEBUG_DUMP
2126 2130
2127 } // namespace autofill 2131 } // namespace autofill
OLDNEW
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698