Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2542563006: Don't animate the notification for pending download (Closed)

Created:
4 years ago by qinmin
Modified:
4 years ago
Reviewers:
gone
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't animate the notification for pending download using stat_sys_download_done, which is the first frame of the animation BUG=670428 Committed: https://crrev.com/601e4f48a3db0aa334f325c03071f5b1d7c4093b Cr-Commit-Position: refs/heads/master@{#435870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
qinmin
PTAL
4 years ago (2016-12-01 22:17:53 UTC) #2
gone
lgtm
4 years ago (2016-12-02 00:13:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542563006/1
4 years ago (2016-12-02 06:14:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 06:49:29 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-02 06:51:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/601e4f48a3db0aa334f325c03071f5b1d7c4093b
Cr-Commit-Position: refs/heads/master@{#435870}

Powered by Google App Engine
This is Rietveld 408576698