Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 2542563003: Update for proto_library.gni (Closed)

Created:
4 years ago by Ramin Halavati
Modified:
4 years ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update for proto_library.gni An optional parameter is added to proto_library.gni that lets the user request adding full version to deps instead of lite version. BUG=670017 Committed: https://crrev.com/ffa07a52a801ce805fd5f01f9984d4df2a71b620 Cr-Commit-Position: refs/heads/master@{#435411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M third_party/protobuf/proto_library.gni View 4 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Ramin Halavati
Hi Peter, You've already LGTMed this change in https://codereview.chromium.org/2448133006/, I'm trying to decrease the number ...
4 years ago (2016-11-30 04:36:51 UTC) #2
Peter Kasting
LGTM
4 years ago (2016-11-30 06:48:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542563003/1
4 years ago (2016-11-30 19:54:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 21:00:03 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-30 21:03:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffa07a52a801ce805fd5f01f9984d4df2a71b620
Cr-Commit-Position: refs/heads/master@{#435411}

Powered by Google App Engine
This is Rietveld 408576698