third_party/WebKit/LayoutTests/http/tests/inspector/security/security-secure-but-malicious.html - Issue 2542533004: Override DevTools security summary when a Safe Browsing warning shows.

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/security/security-secure-but-malicious.html

Issue 2542533004: Override DevTools security summary when a Safe Browsing warning shows. (Closed)

Patch Set: Address review feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/security/security-secure-but-malicious-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/security/security-secure-but-malicious.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-all-resources-secure.html b/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-secure-but-malicious.html

similarity index 75%

copy from third_party/WebKit/LayoutTests/http/tests/inspector/security/security-all-resources-secure.html

copy to third_party/WebKit/LayoutTests/http/tests/inspector/security/security-secure-but-malicious.html

index 68aad98e81591bb00186ee267c72efe61466ebba..b485364755a7f12eacff01b1dfabf6f9a7eb36e2 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-all-resources-secure.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-secure-but-malicious.html

@@ -8,11 +8,13 @@ function test()

/** @type {!Protocol.Security.InsecureContentStatus} */

var insecureContentStatus = { ranMixedContent: false, displayedMixedContent: false, ranContentWithCertErrors: false, displayedContentWithCertErrors: false, ranInsecureContentStyle: Protocol.Security.SecurityState.Insecure, displayedInsecureContentStyle: Protocol.Security.SecurityState.Neutral };

- InspectorTest.mainTarget.model(Security.SecurityModel).dispatchEventToListeners(Security.SecurityModel.Events.SecurityStateChanged, new Security.PageSecurityState(Protocol.Security.SecurityState.Secure, [], insecureContentStatus, true));

+ InspectorTest.mainTarget.model(Security.SecurityModel).dispatchEventToListeners(Security.SecurityModel.Events.SecurityStateChanged, new Security.PageSecurityState(Protocol.Security.SecurityState.Secure, true, [], insecureContentStatus, "Test: Summary Override Text"));

var request = new SDK.NetworkRequest(InspectorTest.mainTarget, 0, "http://foo.test", "https://foo.test", 0, 0, null);

InspectorTest.dispatchRequestFinished(request);

+ InspectorTest.dumpDeepInnerHTML(Security.SecurityPanel._instance()._mainView.contentElement.getElementsByClassName("security-summary-text")[0]);

var explanations = Security.SecurityPanel._instance()._mainView.contentElement.getElementsByClassName("security-explanation");

for (var i = 0; i < explanations.length; i++)

InspectorTest.dumpDeepInnerHTML(explanations[i]);

@@ -21,6 +23,6 @@ function test()

</script>

</head>

-<p>Tests addition of explanation when all page resources are transferred securely (no-mixed-content).</p>

+<p>Tests summary and explanation when all page resources are transferred securely (no-mixed-content) but page is flagged by Google Safe Browsing.</p>

</body>

</html>