headless/lib/headless_web_contents_browsertest.cc - Issue 2542533004: Override DevTools security summary when a Safe Browsing warning shows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/headless_web_contents_browsertest.cc

Issue 2542533004: Override DevTools security summary when a Safe Browsing warning shows. (Closed)

Patch Set: Address review feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/lib/headless_web_contents_browsertest.cc

diff --git a/headless/lib/headless_web_contents_browsertest.cc b/headless/lib/headless_web_contents_browsertest.cc

index 51f519c9055ca60c29d68c267a75e747025e6dbb..18b4295c2b94e42e8db687ebd4652e6a5750af99 100644

--- a/headless/lib/headless_web_contents_browsertest.cc

+++ b/headless/lib/headless_web_contents_browsertest.cc

@@ -88,7 +88,6 @@ class HeadlessWebContentsSecurityTest

void OnSecurityStateChanged(

const security::SecurityStateChangedParams& params) override {

EXPECT_EQ(security::SecurityState::NEUTRAL, params.GetSecurityState());

- EXPECT_TRUE(params.HasExplanations());

FinishAsynchronousTest();

}