Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: content/browser/devtools/protocol/security_handler.cc

Issue 2542533004: Override DevTools security summary when a Safe Browsing warning shows. (Closed)
Patch Set: Address review feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/security_state_strings.grdp ('k') | content/public/browser/security_style_explanations.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/security_handler.cc
diff --git a/content/browser/devtools/protocol/security_handler.cc b/content/browser/devtools/protocol/security_handler.cc
index aa44273bd0bf7d177a82a35f119157763e2b995f..5511ef648345f7baf71df3688b18e547188ce1a9 100644
--- a/content/browser/devtools/protocol/security_handler.cc
+++ b/content/browser/devtools/protocol/security_handler.cc
@@ -129,9 +129,10 @@ void SecurityHandler::DidChangeVisibleSecurityState() {
frontend_->SecurityStateChanged(
security_state,
- Maybe<Explanations>(std::move(explanations)),
- Maybe<Security::InsecureContentStatus>(std::move(insecure_status)),
- Maybe<bool>(security_style_explanations.scheme_is_cryptographic));
+ security_style_explanations.scheme_is_cryptographic,
+ std::move(explanations),
+ std::move(insecure_status),
+ Maybe<std::string>(security_style_explanations.summary));
}
Response SecurityHandler::Enable() {
« no previous file with comments | « components/security_state_strings.grdp ('k') | content/public/browser/security_style_explanations.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698