Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js

Issue 2542533004: Override DevTools security summary when a Safe Browsing warning shows. (Closed)
Patch Set: Parameters for the securityStatusChanged event and related objects are not optional Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js
index f1d91a77fcf4ad9116d763030bd583db249fb9b1..c392c679d7e0f8775a4d2fef4423aaeb3c7bb98e 100644
--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js
@@ -73,15 +73,17 @@ Security.SecurityModel.Events = {
Security.PageSecurityState = class {
/**
* @param {!Protocol.Security.SecurityState} securityState
+ * @param {?string} summaryOverride
dgozman 2016/12/09 20:57:39 Just string.
+ * @param {boolean} schemeIsCryptographic
* @param {!Array<!Protocol.Security.SecurityStateExplanation>} explanations
* @param {?Protocol.Security.InsecureContentStatus} insecureContentStatus
- * @param {boolean} schemeIsCryptographic
*/
- constructor(securityState, explanations, insecureContentStatus, schemeIsCryptographic) {
+ constructor(securityState, summaryOverride, schemeIsCryptographic, explanations, insecureContentStatus) {
this.securityState = securityState;
+ this.summaryOverride = summaryOverride;
+ this.schemeIsCryptographic = schemeIsCryptographic;
this.explanations = explanations;
this.insecureContentStatus = insecureContentStatus;
- this.schemeIsCryptographic = schemeIsCryptographic;
}
};
@@ -97,13 +99,14 @@ Security.SecurityDispatcher = class {
/**
* @override
* @param {!Protocol.Security.SecurityState} securityState
+ * @param {?string} summaryOverride
dgozman 2016/12/09 20:57:39 Just string.
+ * @param {boolean} schemeIsCryptographic
* @param {!Array<!Protocol.Security.SecurityStateExplanation>=} explanations
dgozman 2016/12/09 20:57:39 Pleas remove "=" from the type.
* @param {!Protocol.Security.InsecureContentStatus=} insecureContentStatus
dgozman 2016/12/09 20:57:38 Ditto.
- * @param {boolean=} schemeIsCryptographic
*/
- securityStateChanged(securityState, explanations, insecureContentStatus, schemeIsCryptographic) {
+ securityStateChanged(securityState, summaryOverride, schemeIsCryptographic, explanations, insecureContentStatus) {
var pageSecurityState = new Security.PageSecurityState(
- securityState, explanations || [], insecureContentStatus || null, schemeIsCryptographic || false);
+ securityState, summaryOverride, schemeIsCryptographic, explanations || [], insecureContentStatus || null);
dgozman 2016/12/09 20:57:39 No need for "|| []" and "|| null" anymore.
this._model.dispatchEventToListeners(Security.SecurityModel.Events.SecurityStateChanged, pageSecurityState);
}
};

Powered by Google App Engine
This is Rietveld 408576698