third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html - Issue 2542533004: Override DevTools security summary when a Safe Browsing warning shows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

Issue 2542533004: Override DevTools security summary when a Safe Browsing warning shows. (Closed)

Patch Set: Parameters for the securityStatusChanged event and related objects are not optional Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/security/security-blocked-mixed-content-and-malicious-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/security/security-secure-but-malicious.html » ('j') | third_party/WebKit/Source/core/inspector/browser_protocol.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html b/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

index 2c4ae5fd68d4c3366e6e083d21150c763d03c124..54b2bf653b3675e988bfaa51e966a3350306b0ec 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

@@ -31,7 +31,7 @@ function test()

}

];

- InspectorTest.mainTarget.model(Security.SecurityModel).dispatchEventToListeners(Security.SecurityModel.Events.SecurityStateChanged, new Security.PageSecurityState(Protocol.Security.SecurityState.Secure, explanations, insecureContentStatus, true));

+ InspectorTest.mainTarget.model(Security.SecurityModel).dispatchEventToListeners(Security.SecurityModel.Events.SecurityStateChanged, new Security.PageSecurityState(Protocol.Security.SecurityState.Secure, null, true, explanations, insecureContentStatus));

var request = new SDK.NetworkRequest(InspectorTest.mainTarget, 0, "http://foo.test", "https://foo.test", 0, 0, null);

InspectorTest.dispatchRequestFinished(request);