Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js

Issue 2542533004: Override DevTools security summary when a Safe Browsing warning shows. (Closed)
Patch Set: Address review feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js
index f1d91a77fcf4ad9116d763030bd583db249fb9b1..26286ec9f166f3de75fae64cf9e3e587200dc21b 100644
--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js
@@ -74,12 +74,14 @@ Security.PageSecurityState = class {
/**
* @param {!Protocol.Security.SecurityState} securityState
* @param {!Array<!Protocol.Security.SecurityStateExplanation>} explanations
+ * @param {?string} summary
* @param {?Protocol.Security.InsecureContentStatus} insecureContentStatus
* @param {boolean} schemeIsCryptographic
*/
- constructor(securityState, explanations, insecureContentStatus, schemeIsCryptographic) {
+ constructor(securityState, explanations, summary, insecureContentStatus, schemeIsCryptographic) {
this.securityState = securityState;
this.explanations = explanations;
+ this.summary = summary;
this.insecureContentStatus = insecureContentStatus;
this.schemeIsCryptographic = schemeIsCryptographic;
}
@@ -98,12 +100,13 @@ Security.SecurityDispatcher = class {
* @override
* @param {!Protocol.Security.SecurityState} securityState
* @param {!Array<!Protocol.Security.SecurityStateExplanation>=} explanations
+ * @param {string=} summary
* @param {!Protocol.Security.InsecureContentStatus=} insecureContentStatus
* @param {boolean=} schemeIsCryptographic
*/
- securityStateChanged(securityState, explanations, insecureContentStatus, schemeIsCryptographic) {
+ securityStateChanged(securityState, explanations, summary, insecureContentStatus, schemeIsCryptographic) {
var pageSecurityState = new Security.PageSecurityState(
- securityState, explanations || [], insecureContentStatus || null, schemeIsCryptographic || false);
+ securityState, explanations || [], summary || null, insecureContentStatus || null, schemeIsCryptographic || false);
this._model.dispatchEventToListeners(Security.SecurityModel.Events.SecurityStateChanged, pageSecurityState);
}
};

Powered by Google App Engine
This is Rietveld 408576698