Override DevTools security summary when a Safe Browsing warning shows.

third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @implements {SDK.TargetManager.Observer}
  * @unrestricted
  */
 Security.SecurityPanel = class extends UI.PanelWithSidebar {
   constructor() {
     super('security');
@@ skipping 74 matching lines @@
 
   /**
    * @param {!Protocol.Security.SecurityState} securityState
    */
   setDisplayedInsecureContentStyle(securityState) {
     this._displayedInsecureContentStyle = securityState;
   }
 
   /**
    * @param {!Protocol.Security.SecurityState} newSecurityState
+   * @param {?string} summaryOverride

[dgozman, 2016/12/09 20:57:39]

string

+   * @param {boolean} schemeIsCryptographic
    * @param {!Array<!Protocol.Security.SecurityStateExplanation>} explanations
    * @param {?Protocol.Security.InsecureContentStatus} insecureContentStatus
-   * @param {boolean} schemeIsCryptographic
    */
-  _updateSecurityState(newSecurityState, explanations, insecureContentStatus, schemeIsCryptographic) {
+  _updateSecurityState(newSecurityState, summaryOverride, schemeIsCryptographic, explanations, insecureContentStatus) {
     this._sidebarMainViewElement.setSecurityState(newSecurityState);
-    this._mainView.updateSecurityState(newSecurityState, explanations, insecureContentStatus, schemeIsCryptographic);
+    this._mainView.updateSecurityState(
+        newSecurityState, summaryOverride, schemeIsCryptographic, explanations, insecureContentStatus);
   }
 
   /**
    * @param {!Common.Event} event
    */
   _onSecurityStateChanged(event) {
     var data = /** @type {!Security.PageSecurityState} */ (event.data);
     var securityState = /** @type {!Protocol.Security.SecurityState} */ (data.securityState);
+    var summaryOverride = /** @type {string} */ (data.summaryOverride);
+    var schemeIsCryptographic = /** @type {boolean} */ (data.schemeIsCryptographic);
     var explanations = /** @type {!Array<!Protocol.Security.SecurityStateExplanation>} */ (data.explanations);
     var insecureContentStatus = /** @type {?Protocol.Security.InsecureContentStatus} */ (data.insecureContentStatus);
-    var schemeIsCryptographic = /** @type {boolean} */ (data.schemeIsCryptographic);
-    this._updateSecurityState(securityState, explanations, insecureContentStatus, schemeIsCryptographic);
+    this._updateSecurityState(
+        securityState, summaryOverride, schemeIsCryptographic, explanations, insecureContentStatus);
   }
 
   selectAndSwitchToMainView() {
     // The sidebar element will trigger displaying the main view. Rather than making a redundant call to display the main view, we rely on this.
     this._sidebarMainViewElement.select();
   }
   /**
    * @param {!Security.SecurityPanel.Origin} origin
    */
   showOrigin(origin) {
@@ skipping 507 matching lines @@
     if (explanation.hasCertificate) {
       text.appendChild(
           Security.SecurityPanel.createCertificateViewerButton(Common.UIString('View certificate'), this._panel));
     }
 
     return text;
   }
 
   /**
    * @param {!Protocol.Security.SecurityState} newSecurityState
+   * @param {?string} summaryOverride

[dgozman, 2016/12/09 20:57:39]

string

+   * @param {boolean} schemeIsCryptographic
    * @param {!Array<!Protocol.Security.SecurityStateExplanation>} explanations
    * @param {?Protocol.Security.InsecureContentStatus} insecureContentStatus
-   * @param {boolean} schemeIsCryptographic
    */
-  updateSecurityState(newSecurityState, explanations, insecureContentStatus, schemeIsCryptographic) {
+  updateSecurityState(newSecurityState, summaryOverride, schemeIsCryptographic, explanations, insecureContentStatus) {
     // Remove old state.
     // It's safe to call this even when this._securityState is undefined.
     this._summarySection.classList.remove('security-summary-' + this._securityState);
 
     // Add new state.
     this._securityState = newSecurityState;
     this._summarySection.classList.add('security-summary-' + this._securityState);
     var summaryExplanationStrings = {
       'unknown': Common.UIString('The security of this page is unknown.'),
       'insecure': Common.UIString('This page is not secure (broken HTTPS).'),
       'neutral': Common.UIString('This page is not secure.'),
       'secure': Common.UIString('This page is secure (valid HTTPS).')
     };
-    this._summaryText.textContent = summaryExplanationStrings[this._securityState];
+
+    // Use override summary if present, otherwise use base explanation
+    this._summaryText.textContent = summaryOverride || summaryExplanationStrings[this._securityState];

[dgozman, 2016/12/09 20:57:39]

It's always present, just use it.
We can also remove summaryExplanationStrings.

 
     this._explanations = explanations, this._insecureContentStatus = insecureContentStatus;
     this._schemeIsCryptographic = schemeIsCryptographic;
 
     this._panel.setRanInsecureContentStyle(insecureContentStatus.ranInsecureContentStyle);
     this._panel.setDisplayedInsecureContentStyle(insecureContentStatus.displayedInsecureContentStyle);
 
     this.refreshExplanations();
   }
 
@@ skipping 366 matching lines @@
     var row = this._element.createChild('div', 'details-table-row');
     row.createChild('div').textContent = key;
 
     var valueDiv = row.createChild('div');
     if (typeof value === 'string')
       valueDiv.textContent = value;
     else
       valueDiv.appendChild(value);
   }
 };