Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2542513002: Add package and instance id to CIPD user agent. (Closed)

Created:
4 years ago by iannucci
Modified:
4 years ago
Reviewers:
dnj, Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M cipd/client/cipd/client.go View 2 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
iannucci
4 years ago (2016-11-30 01:41:26 UTC) #1
iannucci
This ends up sending a UserAgent like `cipd 1.3 (infra/tools/cipd/mac-amd64@dd7ffbc69f5a716c78e0e2fad6a8f64e52bad7b1)`
4 years ago (2016-11-30 01:43:05 UTC) #2
Vadim Sh.
lgtm
4 years ago (2016-11-30 01:57:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542513002/1
4 years ago (2016-12-02 00:11:30 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-02 00:18:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/766ec084433f12dfd18a392c29789e412d59c7da

Powered by Google App Engine
This is Rietveld 408576698