Show modified total price for payment instruments.

Show modified total price for payment instruments.

If the merchant specifies custom pricing for a specific payment method,
show the custom total next to the payment method. For example, a custom
price for "visa" cards changes:

   Visa*1111, Jon Smith

to:

   Visa*1111, Jon Smith, $45.00

The feature is hidden behind chrome://flags#web-payments-modifiers until
it is complete.

BUG=660926
Committed: https://crrev.com/eb085ef9baffdd6a595ab158556382075a7e2dc2
Cr-Commit-Position: refs/heads/master@{#435827}

[please use gerrit instead, 2016-11-30 20:32:11]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 20:33:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-11-30 20:36:12]

Description was changed from

==========
Show modified total price for payment instruments.

BUG=660926
==========

to

==========
Show modified total price for payment instruments.

If the merchant specifies custom pricing for a specific payment method,
show the custom total next to the payment method. For example, a custom
price for "visa" cards changes from:

   Visa*1111, Jon Smith

to:

   Visa*1111, Jon Smith, $45.00

BUG=660926
==========

[please use gerrit instead, 2016-11-30 20:38:07]

Patchset #2 (id:20001) has been deleted

[please use gerrit instead, 2016-11-30 20:38:11]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-11-30 20:38:29]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[please use gerrit instead, 2016-11-30 20:39:02]

Description was changed from

==========
Show modified total price for payment instruments.

If the merchant specifies custom pricing for a specific payment method,
show the custom total next to the payment method. For example, a custom
price for "visa" cards changes from:

   Visa*1111, Jon Smith

to:

   Visa*1111, Jon Smith, $45.00

BUG=660926
==========

to

==========
Show modified total price for payment instruments.

If the merchant specifies custom pricing for a specific payment method,
show the custom total next to the payment method. For example, a custom
price for "visa" cards changes:

   Visa*1111, Jon Smith

to:

   Visa*1111, Jon Smith, $45.00

BUG=660926
==========

[commit-bot: I haz the power, 2016-11-30 20:39:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-11-30 20:39:53]

Description was changed from

==========
Show modified total price for payment instruments.

If the merchant specifies custom pricing for a specific payment method,
show the custom total next to the payment method. For example, a custom
price for "visa" cards changes:

   Visa*1111, Jon Smith

to:

   Visa*1111, Jon Smith, $45.00

BUG=660926
==========

to

==========
Show modified total price for payment instruments.

If the merchant specifies custom pricing for a specific payment method,
show the custom total next to the payment method. For example, a custom
price for "visa" cards changes:

   Visa*1111, Jon Smith

to:

   Visa*1111, Jon Smith, $45.00

The feature is hidden behind chrome://flags#web-payments-modifiers until
it is complete.

BUG=660926
==========

[please use gerrit instead, 2016-11-30 20:40:20]

rouslan@chromium.org changed reviewers:
+ ianwen@chromium.org

[please use gerrit instead, 2016-11-30 20:40:21]

Ian, ptal.

[please use gerrit instead, 2016-11-30 20:42:48]

Screenshot in http://crbug.com/660926#c4

[commit-bot: I haz the power, 2016-11-30 22:08:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 22:08:46]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Ian Wen, 2016-11-30 22:16:22]

If you update about flags, you should add corresonding histogram entries.

https://cs.chromium.org/chromium/src/chrome/browser/about_flags.cc?q=AboutFla...

Otherwise, lgtm with some nits.

https://codereview.chromium.org/2542493004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
(right):

https://codereview.chromium.org/2542493004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java:52:
public void setModifiedTotal(String modifiedTotal) {
Nit: add @Nullable to the argument.

https://codereview.chromium.org/2542493004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java
(right):

https://codereview.chromium.org/2542493004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java:142:
protected void updateTertiarylabel(String tertiarylabel) {
Nit: Add @nullable before String

https://codereview.chromium.org/2542493004/diff/40001/chrome/browser/android/...
File chrome/browser/android/chrome_feature_list.cc (right):

https://codereview.chromium.org/2542493004/diff/40001/chrome/browser/android/...
chrome/browser/android/chrome_feature_list.cc:125:
base::FEATURE_DISABLED_BY_DEFAULT};
Q: Do you plan to roll this feature out using variations server?

[please use gerrit instead, 2016-12-01 20:24:37]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 20:24:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-12-01 20:26:50]

rouslan@chromium.org changed reviewers:
+ isherman@chromium.org, tedchoc@chromium.org

[please use gerrit instead, 2016-12-01 20:26:51]

tedchoc, owners ptal chrome_feature_list.h

isherman, owners ptal histograms.xml

https://codereview.chromium.org/2542493004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
(right):

https://codereview.chromium.org/2542493004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java:52:
public void setModifiedTotal(String modifiedTotal) {
On 2016/11/30 22:16:22, Ian Wen wrote:
> Nit: add @Nullable to the argument.

Done.

https://codereview.chromium.org/2542493004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java
(right):

https://codereview.chromium.org/2542493004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java:142:
protected void updateTertiarylabel(String tertiarylabel) {
On 2016/11/30 22:16:22, Ian Wen wrote:
> Nit: Add @nullable before String

Done.

https://codereview.chromium.org/2542493004/diff/40001/chrome/browser/android/...
File chrome/browser/android/chrome_feature_list.cc (right):

https://codereview.chromium.org/2542493004/diff/40001/chrome/browser/android/...
chrome/browser/android/chrome_feature_list.cc:125:
base::FEATURE_DISABLED_BY_DEFAULT};
On 2016/11/30 22:16:22, Ian Wen wrote:
> Q: Do you plan to roll this feature out using variations server?

No.

[Ted C, 2016-12-01 21:28:21]

On 2016/12/01 20:26:51, rouslan wrote:
> tedchoc, owners ptal chrome_feature_list.h

lgtm

Sigh...can you add chrome_feature_list.h to the OWNERS exclusion in
chrome/browser/android?

> 
> isherman, owners ptal histograms.xml
> 
>
https://codereview.chromium.org/2542493004/diff/40001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
> (right):
> 
>
https://codereview.chromium.org/2542493004/diff/40001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java:52:
> public void setModifiedTotal(String modifiedTotal) {
> On 2016/11/30 22:16:22, Ian Wen wrote:
> > Nit: add @Nullable to the argument.
> 
> Done.
> 
>
https://codereview.chromium.org/2542493004/diff/40001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java
> (right):
> 
>
https://codereview.chromium.org/2542493004/diff/40001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java:142:
> protected void updateTertiarylabel(String tertiarylabel) {
> On 2016/11/30 22:16:22, Ian Wen wrote:
> > Nit: Add @nullable before String
> 
> Done.
> 
>
https://codereview.chromium.org/2542493004/diff/40001/chrome/browser/android/...
> File chrome/browser/android/chrome_feature_list.cc (right):
> 
>
https://codereview.chromium.org/2542493004/diff/40001/chrome/browser/android/...
> chrome/browser/android/chrome_feature_list.cc:125:
> base::FEATURE_DISABLED_BY_DEFAULT};
> On 2016/11/30 22:16:22, Ian Wen wrote:
> > Q: Do you plan to roll this feature out using variations server?
> 
> No.

[commit-bot: I haz the power, 2016-12-01 22:08:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 22:08:02]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2016-12-01 23:53:59]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 23:54:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-12-01 23:56:24]

On 2016/12/01 21:28:21, Ted C wrote:
> Sigh...can you add chrome_feature_list.h to the OWNERS exclusion in
> chrome/browser/android?

Done

[commit-bot: I haz the power, 2016-12-02 01:27:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 01:27:40]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-12-02 01:42:35]

histograms.xml lgtm

[please use gerrit instead, 2016-12-02 02:13:34]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-12-02 02:13:35]

The patchset sent to the CQ was uploaded after l-g-t-m from ianwen@chromium.org,
tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2542493004/#ps80001
(title: "Let anyone review chrome_feature_list.h")

[commit-bot: I haz the power, 2016-12-02 02:13:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 02:19:23]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480644814418400,
"parent_rev": "21431fe45ccf03895e03433e96a5629cae34fadd", "commit_rev":
"463092b9bb493e8dfe70d312bb2500a1afc3c4fb"}

[commit-bot: I haz the power, 2016-12-02 02:19:49]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-12-02 02:22:34]

Description was changed from

==========
Show modified total price for payment instruments.

If the merchant specifies custom pricing for a specific payment method,
show the custom total next to the payment method. For example, a custom
price for "visa" cards changes:

   Visa*1111, Jon Smith

to:

   Visa*1111, Jon Smith, $45.00

The feature is hidden behind chrome://flags#web-payments-modifiers until
it is complete.

BUG=660926
==========

to

==========
Show modified total price for payment instruments.

If the merchant specifies custom pricing for a specific payment method,
show the custom total next to the payment method. For example, a custom
price for "visa" cards changes:

   Visa*1111, Jon Smith

to:

   Visa*1111, Jon Smith, $45.00

The feature is hidden behind chrome://flags#web-payments-modifiers until
it is complete.

BUG=660926

Committed: https://crrev.com/eb085ef9baffdd6a595ab158556382075a7e2dc2
Cr-Commit-Position: refs/heads/master@{#435827}
==========

[commit-bot: I haz the power, 2016-12-02 02:22:35]

Patchset 3 (id:??) landed as
https://crrev.com/eb085ef9baffdd6a595ab158556382075a7e2dc2
Cr-Commit-Position: refs/heads/master@{#435827}