Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2542493004: Show modified total price for payment instruments. (Closed)

Created:
4 years ago by please use gerrit instead
Modified:
4 years ago
Reviewers:
Ted C, Ian Wen, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show modified total price for payment instruments. If the merchant specifies custom pricing for a specific payment method, show the custom total next to the payment method. For example, a custom price for "visa" cards changes: Visa*1111, Jon Smith to: Visa*1111, Jon Smith, $45.00 The feature is hidden behind chrome://flags#web-payments-modifiers until it is complete. BUG=660926 Committed: https://crrev.com/eb085ef9baffdd6a595ab158556382075a7e2dc2 Cr-Commit-Position: refs/heads/master@{#435827}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Patch Set 3 : Let anyone review chrome_feature_list.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java View 1 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 4 chunks +50 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/android/OWNERS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 35 (25 generated)
please use gerrit instead
Ian, ptal.
4 years ago (2016-11-30 20:40:21 UTC) #11
please use gerrit instead
Screenshot in http://crbug.com/660926#c4
4 years ago (2016-11-30 20:42:48 UTC) #12
Ian Wen
If you update about flags, you should add corresonding histogram entries. https://cs.chromium.org/chromium/src/chrome/browser/about_flags.cc?q=AboutFlagsHistogramTest&sq=package:chromium&l=661&dr=C Otherwise, lgtm with ...
4 years ago (2016-11-30 22:16:22 UTC) #15
please use gerrit instead
tedchoc, owners ptal chrome_feature_list.h isherman, owners ptal histograms.xml https://codereview.chromium.org/2542493004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java File chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java (right): https://codereview.chromium.org/2542493004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java#newcode52 chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java:52: public ...
4 years ago (2016-12-01 20:26:51 UTC) #19
Ted C
On 2016/12/01 20:26:51, rouslan wrote: > tedchoc, owners ptal chrome_feature_list.h lgtm Sigh...can you add chrome_feature_list.h ...
4 years ago (2016-12-01 21:28:21 UTC) #20
please use gerrit instead
On 2016/12/01 21:28:21, Ted C wrote: > Sigh...can you add chrome_feature_list.h to the OWNERS exclusion ...
4 years ago (2016-12-01 23:56:24 UTC) #25
Ilya Sherman
histograms.xml lgtm
4 years ago (2016-12-02 01:42:35 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542493004/80001
4 years ago (2016-12-02 02:13:54 UTC) #31
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years ago (2016-12-02 02:19:49 UTC) #33
commit-bot: I haz the power
4 years ago (2016-12-02 02:22:35 UTC) #35
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eb085ef9baffdd6a595ab158556382075a7e2dc2
Cr-Commit-Position: refs/heads/master@{#435827}

Powered by Google App Engine
This is Rietveld 408576698