Replace kCanMaximize/Minimize/Resize with kResizeBehavior.

Replace kCanMaximize/Minimize/Resize with kResizeBehavior.

A single property helps mus avoid lots of little IPC calls.

Change the default value to allow resize (matches old properties).

Add WidgetDelegate::GetResizeBehavior.
Nix DesktopWindowTreeHostMus::GetResizeBehaviorFromDelegate.

Fix NativeWidgetMus::ConfigurePropertiesForNewWindow casting.
(primitive property types should be serialized as int64_t)

TODO: Add ui::mojom::kResizeBehaviorAll?
TODO: Remove maximize from CreateTestWindowWithDelegateAndType?

BUG=669290
TEST=No window resize/min/max behavior changes or regressions.
R=sky@chromium.org

Committed: https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b
Cr-Commit-Position: refs/heads/master@{#435395}

[msw, 2016-11-30 00:12:17]

Description was changed from

==========
Replace kCanMaximize/Minimize/Resize with kResizeBehavior.

A single property helps mus avoid lots of little IPC calls.
Add WidgetDelegate::GetResizeBehavior.
Nix DesktopWindowTreeHostMus::GetResizeBehaviorFromDelegate.

BUG=669290
TEST=No window resize/min/max behavior changes or regressions.
R=sky@chromium.org
==========

to

==========
Replace kCanMaximize/Minimize/Resize with kResizeBehavior.

A single property helps mus avoid lots of little IPC calls.
Add WidgetDelegate::GetResizeBehavior.
Nix DesktopWindowTreeHostMus::GetResizeBehaviorFromDelegate.

TODO: Add ui::mojom::kResizeBehaviorAll?

BUG=669290
TEST=No window resize/min/max behavior changes or regressions.
R=sky@chromium.org
==========

[msw, 2016-11-30 01:03:21]

Description was changed from

==========
Replace kCanMaximize/Minimize/Resize with kResizeBehavior.

A single property helps mus avoid lots of little IPC calls.
Add WidgetDelegate::GetResizeBehavior.
Nix DesktopWindowTreeHostMus::GetResizeBehaviorFromDelegate.

TODO: Add ui::mojom::kResizeBehaviorAll?

BUG=669290
TEST=No window resize/min/max behavior changes or regressions.
R=sky@chromium.org
==========

to

==========
Replace kCanMaximize/Minimize/Resize with kResizeBehavior.

A single property helps mus avoid lots of little IPC calls.

Change the default value to allow resize (matches old properties).

Add WidgetDelegate::GetResizeBehavior.
Nix DesktopWindowTreeHostMus::GetResizeBehaviorFromDelegate.

TODO: Add ui::mojom::kResizeBehaviorAll?

BUG=669290
TEST=No window resize/min/max behavior changes or regressions.
R=sky@chromium.org
==========

[msw, 2016-11-30 01:13:02]

Description was changed from

==========
Replace kCanMaximize/Minimize/Resize with kResizeBehavior.

A single property helps mus avoid lots of little IPC calls.

Change the default value to allow resize (matches old properties).

Add WidgetDelegate::GetResizeBehavior.
Nix DesktopWindowTreeHostMus::GetResizeBehaviorFromDelegate.

TODO: Add ui::mojom::kResizeBehaviorAll?

BUG=669290
TEST=No window resize/min/max behavior changes or regressions.
R=sky@chromium.org
==========

to

==========
Replace kCanMaximize/Minimize/Resize with kResizeBehavior.

A single property helps mus avoid lots of little IPC calls.

Change the default value to allow resize (matches old properties).

Add WidgetDelegate::GetResizeBehavior.
Nix DesktopWindowTreeHostMus::GetResizeBehaviorFromDelegate.

Fix NativeWidgetMus::ConfigurePropertiesForNewWindow casting.
(primitive property types should be serialized as int64_t)

TODO: Add ui::mojom::kResizeBehaviorAll?
TODO: Remove maximize from CreateTestWindowWithDelegateAndType?

BUG=669290
TEST=No window resize/min/max behavior changes or regressions.
R=sky@chromium.org
==========

[msw, 2016-11-30 01:27:07]

Hey Scott, please take a look; thanks!

[msw, 2016-11-30 01:27:16]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 01:28:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 01:37:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 01:37:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sky, 2016-11-30 03:17:28]

LGTM

https://codereview.chromium.org/2542493002/diff/20001/ash/wm/workspace/worksp...
File ash/wm/workspace/workspace_window_resizer_unittest.cc (right):

https://codereview.chromium.org/2542493002/diff/20001/ash/wm/workspace/worksp...
ash/wm/workspace/workspace_window_resizer_unittest.cc:556:
ui::mojom::kResizeBehaviorCanResize |
In some other cases you don't set resize as well. I'm guessing it doesn't matter
for the tests.

https://codereview.chromium.org/2542493002/diff/20001/ui/views/mus/native_wid...
File ui/views/mus/native_widget_mus.cc (right):

https://codereview.chromium.org/2542493002/diff/20001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:674:
mojo::ConvertTo<std::vector<uint8_t>>(static_cast<int64_t>(
optional as this code is going away at some point: use
PropertyConverter::PrimitiveType here and 682.

[msw, 2016-11-30 18:16:37]

https://codereview.chromium.org/2542493002/diff/20001/ash/wm/workspace/worksp...
File ash/wm/workspace/workspace_window_resizer_unittest.cc (right):

https://codereview.chromium.org/2542493002/diff/20001/ash/wm/workspace/worksp...
ash/wm/workspace/workspace_window_resizer_unittest.cc:556:
ui::mojom::kResizeBehaviorCanResize |
On 2016/11/30 03:17:28, sky wrote:
> In some other cases you don't set resize as well. I'm guessing it doesn't
matter
> for the tests.

Yeah, I made sure all the tests passed locally (except x11, I don't have a build
on hand for those). I generally applied the minimal required behavior.

https://codereview.chromium.org/2542493002/diff/20001/ui/views/mus/native_wid...
File ui/views/mus/native_widget_mus.cc (right):

https://codereview.chromium.org/2542493002/diff/20001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:674:
mojo::ConvertTo<std::vector<uint8_t>>(static_cast<int64_t>(
On 2016/11/30 03:17:28, sky wrote:
> optional as this code is going away at some point: use
> PropertyConverter::PrimitiveType here and 682.

Done.

[msw, 2016-11-30 18:16:43]

The CQ bit was checked by msw@chromium.org

[msw, 2016-11-30 18:16:43]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2542493002/#ps40001
(title: "Use aura::PropertyConverter::PrimitiveType fix deps.")

[commit-bot: I haz the power, 2016-11-30 18:17:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 18:59:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 18:59:20]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[msw, 2016-11-30 19:08:19]

The CQ bit was checked by msw@chromium.org

[msw, 2016-11-30 19:08:20]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2542493002/#ps60001
(title: "Fix int->bool compile issue.")

[commit-bot: I haz the power, 2016-11-30 19:08:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 20:17:10]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480532899968110,
"parent_rev": "7e3946156768944f49c0255d4712903db6ffec63", "commit_rev":
"ba5f082bd3200d15a508b90337b76d7aee4f93d7"}

[commit-bot: I haz the power, 2016-11-30 20:17:36]

Description was changed from

==========
Replace kCanMaximize/Minimize/Resize with kResizeBehavior.

A single property helps mus avoid lots of little IPC calls.

Change the default value to allow resize (matches old properties).

Add WidgetDelegate::GetResizeBehavior.
Nix DesktopWindowTreeHostMus::GetResizeBehaviorFromDelegate.

Fix NativeWidgetMus::ConfigurePropertiesForNewWindow casting.
(primitive property types should be serialized as int64_t)

TODO: Add ui::mojom::kResizeBehaviorAll?
TODO: Remove maximize from CreateTestWindowWithDelegateAndType?

BUG=669290
TEST=No window resize/min/max behavior changes or regressions.
R=sky@chromium.org
==========

to

==========
Replace kCanMaximize/Minimize/Resize with kResizeBehavior.

A single property helps mus avoid lots of little IPC calls.

Change the default value to allow resize (matches old properties).

Add WidgetDelegate::GetResizeBehavior.
Nix DesktopWindowTreeHostMus::GetResizeBehaviorFromDelegate.

Fix NativeWidgetMus::ConfigurePropertiesForNewWindow casting.
(primitive property types should be serialized as int64_t)

TODO: Add ui::mojom::kResizeBehaviorAll?
TODO: Remove maximize from CreateTestWindowWithDelegateAndType?

BUG=669290
TEST=No window resize/min/max behavior changes or regressions.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-11-30 20:17:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-30 20:20:26]

Description was changed from

==========
Replace kCanMaximize/Minimize/Resize with kResizeBehavior.

A single property helps mus avoid lots of little IPC calls.

Change the default value to allow resize (matches old properties).

Add WidgetDelegate::GetResizeBehavior.
Nix DesktopWindowTreeHostMus::GetResizeBehaviorFromDelegate.

Fix NativeWidgetMus::ConfigurePropertiesForNewWindow casting.
(primitive property types should be serialized as int64_t)

TODO: Add ui::mojom::kResizeBehaviorAll?
TODO: Remove maximize from CreateTestWindowWithDelegateAndType?

BUG=669290
TEST=No window resize/min/max behavior changes or regressions.
R=sky@chromium.org
==========

to

==========
Replace kCanMaximize/Minimize/Resize with kResizeBehavior.

A single property helps mus avoid lots of little IPC calls.

Change the default value to allow resize (matches old properties).

Add WidgetDelegate::GetResizeBehavior.
Nix DesktopWindowTreeHostMus::GetResizeBehaviorFromDelegate.

Fix NativeWidgetMus::ConfigurePropertiesForNewWindow casting.
(primitive property types should be serialized as int64_t)

TODO: Add ui::mojom::kResizeBehaviorAll?
TODO: Remove maximize from CreateTestWindowWithDelegateAndType?

BUG=669290
TEST=No window resize/min/max behavior changes or regressions.
R=sky@chromium.org

Committed: https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b
Cr-Commit-Position: refs/heads/master@{#435395}
==========

[commit-bot: I haz the power, 2016-11-30 20:20:30]

Patchset 4 (id:??) landed as
https://crrev.com/b00a80d7cbcb9dc12278a13bd56b41a008cb978b
Cr-Commit-Position: refs/heads/master@{#435395}