Add paused download into SharedPreferences

Add paused download into SharedPreferences

When download is manually paused, currently it is not stored in SharedPreferences.
This is reasonable if download can only be resumed from the notification.
However, with download home, resuming a paused download will require Chrome to know the notification Id.
This CL stores the paused download into SharedPreferences.
So that the notification Id can be retrieved when resuming a download from download Home.

BUG=669702
Committed: https://crrev.com/927312747a47d9aef1b08217f590c6b83c13e174
Cr-Commit-Position: refs/heads/master@{#435266}

[qinmin, 2016-11-29 23:31:54]

qinmin@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[qinmin, 2016-11-29 23:31:55]

PTAL

[gone, 2016-11-29 23:58:37]

lgtm

https://codereview.chromium.org/2542483002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2542483002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:161:
allowMeteredConnection = true;
can this just be shortened to 

allowMeteredConnection =
mDownloadSharedPreferenceEntries.get(i).canDownloadWhileMetered;

https://codereview.chromium.org/2542483002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:350:
// if download is already paused, do nothing.
Capitalize if

https://codereview.chromium.org/2542483002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
(right):

https://codereview.chromium.org/2542483002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java:190:
Set<String> notifications = new HashSet<String>();
new HashSet<>()

[qinmin, 2016-11-30 00:44:48]

https://codereview.chromium.org/2542483002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2542483002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:161:
allowMeteredConnection = true;
On 2016/11/29 23:58:37, dfalcantara (check my queue) wrote:
> can this just be shortened to 
> 
> allowMeteredConnection =
> mDownloadSharedPreferenceEntries.get(i).canDownloadWhileMetered;

If I do that, then allowedMeteredConnection can be reset to false if we later
encounter a DownloadSharedPreferenceEntry whose canDownloadWhileMetered is
false.

I can do an early break here though. Or change the statement to
allowMeteredConnection |=
mDownloadSharedPreferenceEntries.get(i).canDownloadWhileMetered

https://codereview.chromium.org/2542483002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:350:
// if download is already paused, do nothing.
On 2016/11/29 23:58:37, dfalcantara (check my queue) wrote:
> Capitalize if

Done.

https://codereview.chromium.org/2542483002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
(right):

https://codereview.chromium.org/2542483002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java:190:
Set<String> notifications = new HashSet<String>();
On 2016/11/29 23:58:37, dfalcantara (check my queue) wrote:
> new HashSet<>()

Done.

[qinmin, 2016-11-30 00:44:57]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-11-30 00:44:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2542483002/#ps20001
(title: "addressing comments")

[commit-bot: I haz the power, 2016-11-30 00:45:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 02:47:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 02:47:42]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[qinmin, 2016-11-30 15:27:55]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2016-11-30 15:28:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 15:35:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480519675009570,
"parent_rev": "c334b779435fb02f69cfd309ca4771e9dcfd7618", "commit_rev":
"f9b38315c7f047b1135db1d953af28eca929d4ed"}

[commit-bot: I haz the power, 2016-11-30 15:36:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-30 15:38:18]

Description was changed from

==========
Add paused download into SharedPreferences

When download is manually paused, currently it is not stored in
SharedPreferences.
This is reasonable if download can only be resumed from the notification.
However, with download home, resuming a paused download will require Chrome to
know the notification Id.
This CL stores the paused download into SharedPreferences.
So that the notification Id can be retrieved when resuming a download from
download Home.

BUG=669702
==========

to

==========
Add paused download into SharedPreferences

When download is manually paused, currently it is not stored in
SharedPreferences.
This is reasonable if download can only be resumed from the notification.
However, with download home, resuming a paused download will require Chrome to
know the notification Id.
This CL stores the paused download into SharedPreferences.
So that the notification Id can be retrieved when resuming a download from
download Home.

BUG=669702

Committed: https://crrev.com/927312747a47d9aef1b08217f590c6b83c13e174
Cr-Commit-Position: refs/heads/master@{#435266}
==========

[commit-bot: I haz the power, 2016-11-30 15:38:19]

Patchset 2 (id:??) landed as
https://crrev.com/927312747a47d9aef1b08217f590c6b83c13e174
Cr-Commit-Position: refs/heads/master@{#435266}