Do not try to convert point to root coordinate space when |local_frame_id_| is invalid.

Do not try to convert point to root coordinate space when |local_frame_id_| is invalid.

It appears that we might receive IPC which would trigger this code path
while |local_frame_id_| is not valid. It is reasonable to verify the
validity of |local_frame_id_| before passing the SurfaceId to
CrossProcessFrameConnector for point transform.

This CL also attempts to re-enable
SSLUITest.TestUnauthenticatedFrameNavigation with --site-per-process (which was
most probably flaky due to the issue above).

BUG=668913
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/2677ed350ab354042313bc3b47c371d7a3b67292
Cr-Commit-Position: refs/heads/master@{#435744}

[EhsanK, 2016-11-29 23:05:28]

Description was changed from

==========
Do not try to convert point to root coordinate space when |local_frame_id_| is
invalid.

It appears that we might receive IPC which would trigger this code path
while |local_frame_id_| is not valid. It is reasonable to verify the
validity of |local_frame_id_| before passing the SurfaceId to
CrossProcessFrameConnector for point transform.

This CL also attempts to re-enable
SSLUITest.TestUnauthenticatedFrameNavigation with --site-per-process (which was
most probably flaky due to the issue above).

BUG=668913
==========

to

==========
Do not try to convert point to root coordinate space when |local_frame_id_| is
invalid.

It appears that we might receive IPC which would trigger this code path
while |local_frame_id_| is not valid. It is reasonable to verify the
validity of |local_frame_id_| before passing the SurfaceId to
CrossProcessFrameConnector for point transform.

This CL also attempts to re-enable
SSLUITest.TestUnauthenticatedFrameNavigation with --site-per-process (which was
most probably flaky due to the issue above).

BUG=668913
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[EhsanK, 2016-11-29 23:05:31]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 23:06:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[EhsanK, 2016-11-29 23:56:56]

ekaramad@chromium.org changed reviewers:
+ kenrb@chromium.org

[EhsanK, 2016-11-29 23:56:57]

PTAL.

I should emphasize say that I have not been able to make the test flake locally
with or without this change.

[commit-bot: I haz the power, 2016-11-30 01:08:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 01:08:44]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_site_isolation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[kenrb, 2016-12-01 15:05:47]

lgtm

[EhsanK, 2016-12-01 17:27:54]

ekaramad@chromium.org changed reviewers:
+ creis@chromium.org

[EhsanK, 2016-12-01 17:27:54]

creis@chromium.org: Please review changes in 

Charlie, could you please take a look?

[EhsanK, 2016-12-01 17:28:46]

ekaramad@chromium.org changed reviewers:
+ sky@chromium.org

[EhsanK, 2016-12-01 17:28:47]

sky@chromium.org: Please review changes in 

Adding sky@ as chrome/ owner. PTAL.

[sky, 2016-12-01 20:12:34]

LGTM

[Charlie Reis, 2016-12-01 21:08:32]

LGTM

[EhsanK, 2016-12-01 21:26:10]

Thanks for the reviews!

[EhsanK, 2016-12-01 21:26:14]

The CQ bit was checked by ekaramad@chromium.org

[commit-bot: I haz the power, 2016-12-01 21:26:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 22:44:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480627574726110, "parent_rev":
"e1404fbd0bede593bd3c082dafe7d26445ff995a", "commit_rev":
"d51137677b723c6fd59b11e6722a90c0bcf3355a"}

[commit-bot: I haz the power, 2016-12-01 22:45:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-01 22:49:02]

Description was changed from

==========
Do not try to convert point to root coordinate space when |local_frame_id_| is
invalid.

It appears that we might receive IPC which would trigger this code path
while |local_frame_id_| is not valid. It is reasonable to verify the
validity of |local_frame_id_| before passing the SurfaceId to
CrossProcessFrameConnector for point transform.

This CL also attempts to re-enable
SSLUITest.TestUnauthenticatedFrameNavigation with --site-per-process (which was
most probably flaky due to the issue above).

BUG=668913
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Do not try to convert point to root coordinate space when |local_frame_id_| is
invalid.

It appears that we might receive IPC which would trigger this code path
while |local_frame_id_| is not valid. It is reasonable to verify the
validity of |local_frame_id_| before passing the SurfaceId to
CrossProcessFrameConnector for point transform.

This CL also attempts to re-enable
SSLUITest.TestUnauthenticatedFrameNavigation with --site-per-process (which was
most probably flaky due to the issue above).

BUG=668913
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/2677ed350ab354042313bc3b47c371d7a3b67292
Cr-Commit-Position: refs/heads/master@{#435744}
==========

[commit-bot: I haz the power, 2016-12-01 22:49:04]

Patchset 1 (id:??) landed as
https://crrev.com/2677ed350ab354042313bc3b47c371d7a3b67292
Cr-Commit-Position: refs/heads/master@{#435744}