Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1169)

Unified Diff: content/browser/renderer_host/input/tap_suppression_controller_unittest.cc

Issue 2542453003: Suppress LongPress/Tap, and TwoFingerTap when TapDown cancels a fling. (Closed)
Patch Set: clarification comments added. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/tap_suppression_controller_unittest.cc
diff --git a/content/browser/renderer_host/input/tap_suppression_controller_unittest.cc b/content/browser/renderer_host/input/tap_suppression_controller_unittest.cc
index 3dd0834d236c2290b6d891fbbee0d319d0c161f1..195a49629f03becb6f6160acb9805b2523c77eb6 100644
--- a/content/browser/renderer_host/input/tap_suppression_controller_unittest.cc
+++ b/content/browser/renderer_host/input/tap_suppression_controller_unittest.cc
@@ -22,6 +22,7 @@ class MockTapSuppressionController : public TapSuppressionController,
using TapSuppressionController::GFC_IN_PROGRESS;
using TapSuppressionController::TAP_DOWN_STASHED;
using TapSuppressionController::LAST_CANCEL_STOPPED_FLING;
+ using TapSuppressionController::SUPPRESSING_TAPS;
enum Action {
NONE = 0,
@@ -104,6 +105,10 @@ class MockTapSuppressionController : public TapSuppressionController,
// TapSuppressionControllerClient implementation
void DropStashedTapDown() override { last_actions_ |= TAP_DOWN_DROPPED; }
+ void ForwardStashedGestureEvents() override {
+ last_actions_ |= STASHED_TAP_DOWN_FORWARDED;
+ }
+
void ForwardStashedTapDown() override {
last_actions_ |= STASHED_TAP_DOWN_FORWARDED;
}
@@ -178,7 +183,7 @@ TEST_F(TapSuppressionControllerTest, GFCAckBeforeTapFast) {
EXPECT_EQ(MockTapSuppressionController::TAP_UP_SUPPRESSED |
MockTapSuppressionController::TAP_DOWN_DROPPED,
tap_suppression_controller_->last_actions());
- EXPECT_EQ(MockTapSuppressionController::NOTHING,
+ EXPECT_EQ(MockTapSuppressionController::SUPPRESSING_TAPS,
tap_suppression_controller_->state());
}
@@ -219,7 +224,7 @@ TEST_F(TapSuppressionControllerTest, GFCAckBeforeTapInsufficientlyLateTapUp) {
EXPECT_EQ(MockTapSuppressionController::TAP_UP_SUPPRESSED |
MockTapSuppressionController::TAP_DOWN_DROPPED,
tap_suppression_controller_->last_actions());
- EXPECT_EQ(MockTapSuppressionController::NOTHING,
+ EXPECT_EQ(MockTapSuppressionController::SUPPRESSING_TAPS,
tap_suppression_controller_->state());
}
@@ -252,14 +257,16 @@ TEST_F(TapSuppressionControllerTest, GFCAckBeforeTapSufficientlyLateTapUp) {
tap_suppression_controller_->AdvanceTime(TimeDelta::FromMilliseconds(13));
EXPECT_EQ(MockTapSuppressionController::STASHED_TAP_DOWN_FORWARDED,
tap_suppression_controller_->last_actions());
- EXPECT_EQ(MockTapSuppressionController::NOTHING,
+ EXPECT_EQ(MockTapSuppressionController::SUPPRESSING_TAPS,
tap_suppression_controller_->state());
- // Send TapUp. This TapUp should not be suppressed.
+ // Send TapUp. This TapUp should be still suppressed.
+ // LongTap should be suppressed when the previously suppressed TapDown is
+ // forwarded because of the timer expiration.
tap_suppression_controller_->SendTapUp();
- EXPECT_EQ(MockTapSuppressionController::TAP_UP_FORWARDED,
+ EXPECT_EQ(MockTapSuppressionController::TAP_UP_SUPPRESSED,
tap_suppression_controller_->last_actions());
- EXPECT_EQ(MockTapSuppressionController::NOTHING,
+ EXPECT_EQ(MockTapSuppressionController::SUPPRESSING_TAPS,
tap_suppression_controller_->state());
}
@@ -300,7 +307,7 @@ TEST_F(TapSuppressionControllerTest, GFCAckBeforeTapInsufficientlyLateTapDown) {
EXPECT_EQ(MockTapSuppressionController::TAP_UP_SUPPRESSED |
MockTapSuppressionController::TAP_DOWN_DROPPED,
tap_suppression_controller_->last_actions());
- EXPECT_EQ(MockTapSuppressionController::NOTHING,
+ EXPECT_EQ(MockTapSuppressionController::SUPPRESSING_TAPS,
tap_suppression_controller_->state());
}
@@ -406,7 +413,7 @@ TEST_F(TapSuppressionControllerTest, GFCAckProcessedAfterTapFast) {
EXPECT_EQ(MockTapSuppressionController::TAP_UP_SUPPRESSED |
MockTapSuppressionController::TAP_DOWN_DROPPED,
tap_suppression_controller_->last_actions());
- EXPECT_EQ(MockTapSuppressionController::NOTHING,
+ EXPECT_EQ(MockTapSuppressionController::SUPPRESSING_TAPS,
tap_suppression_controller_->state());
}
@@ -447,7 +454,7 @@ TEST_F(TapSuppressionControllerTest, GFCAckAfterTapInsufficientlyLateTapUp) {
EXPECT_EQ(MockTapSuppressionController::TAP_UP_SUPPRESSED |
MockTapSuppressionController::TAP_DOWN_DROPPED,
tap_suppression_controller_->last_actions());
- EXPECT_EQ(MockTapSuppressionController::NOTHING,
+ EXPECT_EQ(MockTapSuppressionController::SUPPRESSING_TAPS,
tap_suppression_controller_->state());
}
@@ -480,14 +487,16 @@ TEST_F(TapSuppressionControllerTest, GFCAckAfterTapSufficientlyLateTapUp) {
tap_suppression_controller_->AdvanceTime(TimeDelta::FromMilliseconds(13));
EXPECT_EQ(MockTapSuppressionController::STASHED_TAP_DOWN_FORWARDED,
tap_suppression_controller_->last_actions());
- EXPECT_EQ(MockTapSuppressionController::NOTHING,
+ EXPECT_EQ(MockTapSuppressionController::SUPPRESSING_TAPS,
tap_suppression_controller_->state());
- // Send TapUp. This TapUp should not be suppressed.
+ // Send TapUp. This TapUp should be still suppressed.
+ // LongTap should be suppressed when the previously suppressed TapDown is
+ // forwarded because of timer expiration.
tap_suppression_controller_->SendTapUp();
- EXPECT_EQ(MockTapSuppressionController::TAP_UP_FORWARDED,
+ EXPECT_EQ(MockTapSuppressionController::TAP_UP_SUPPRESSED,
tap_suppression_controller_->last_actions());
- EXPECT_EQ(MockTapSuppressionController::NOTHING,
+ EXPECT_EQ(MockTapSuppressionController::SUPPRESSING_TAPS,
tap_suppression_controller_->state());
}

Powered by Google App Engine
This is Rietveld 408576698