Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Unified Diff: content/browser/renderer_host/input/input_router_config_helper.cc

Issue 2542453003: Suppress LongPress/Tap, and TwoFingerTap when TapDown cancels a fling. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/input_router_config_helper.cc
diff --git a/content/browser/renderer_host/input/input_router_config_helper.cc b/content/browser/renderer_host/input/input_router_config_helper.cc
index 53aaee3f8800c06d437dbbe1be75a8147c05596e..f849aed6ca61fc4efc9edab88559dd2aa4d7f46e 100644
--- a/content/browser/renderer_host/input/input_router_config_helper.cc
+++ b/content/browser/renderer_host/input/input_router_config_helper.cc
@@ -49,9 +49,10 @@ GestureEventQueue::Config GetGestureEventQueueConfig() {
config.touchscreen_tap_suppression_config.max_cancel_to_down_time =
base::TimeDelta::FromMilliseconds(
gesture_config->fling_max_cancel_to_down_time_in_ms());
+ // Long press must get suppressed when a tap down cancels a fling.
config.touchscreen_tap_suppression_config.max_tap_gap_time =
base::TimeDelta::FromMilliseconds(
- gesture_config->long_press_time_in_ms());
+ gesture_config->long_press_time_in_ms() * 1.1);
tdresser 2016/12/01 18:57:59 Maybe elaborate a bit here - why does this need to
sahel 2016/12/06 15:18:13 Done.
config.touchpad_tap_suppression_config.enabled =
gesture_config->fling_touchpad_tap_suppression_enabled();

Powered by Google App Engine
This is Rietveld 408576698