Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: chrome/browser/ui/webui/signin/login_ui_service.cc

Issue 2542423002: Revert of Use the modal view when signing in from chrome.identity extension API. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/signin/login_ui_service.cc
diff --git a/chrome/browser/ui/webui/signin/login_ui_service.cc b/chrome/browser/ui/webui/signin/login_ui_service.cc
index 11c4093305b68dcdd15f0d171910a2ef2309ab15..dad71a812425d20599814ce6355791be8dc1349d 100644
--- a/chrome/browser/ui/webui/signin/login_ui_service.cc
+++ b/chrome/browser/ui/webui/signin/login_ui_service.cc
@@ -10,7 +10,6 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/chrome_pages.h"
-#include "chrome/browser/ui/profile_chooser_constants.h"
#include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
#include "chrome/browser/ui/user_manager.h"
#include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
@@ -59,15 +58,9 @@ void LoginUIService::ShowLoginPopup() {
NOTREACHED();
#else
chrome::ScopedTabbedBrowserDisplayer displayer(profile_);
- profiles::BubbleViewMode signin_mode = profiles::BUBBLE_VIEW_MODE_GAIA_SIGNIN;
- if (SigninViewController::ShouldShowModalSigninForMode(signin_mode)) {
- displayer.browser()->ShowModalSigninWindow(signin_mode,
- signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS);
- } else {
- chrome::ShowBrowserSignin(
- displayer.browser(),
- signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS);
- }
+ chrome::ShowBrowserSignin(
+ displayer.browser(),
+ signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS);
#endif
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698