Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2542403003: Make ThreadChecker zero-sized

Created:
4 years ago by Primiano Tucci (use gerrit)
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ThreadChecker zero-sized TODO CL description Mr compiler, would you please make this empty struct zero sized? Context: [chromium-dev] ThreadChecker vs. NonThreadSafe BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M base/threading/thread_checker.h View 1 chunk +3 lines, -0 lines 0 comments Download
M base/threading/thread_checker_unittest.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org to run a CQ dry run
4 years ago (2016-12-02 16:20:07 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542403003/1
4 years ago (2016-12-02 16:20:25 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-02 16:27:01 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-02 16:27:05 UTC) #4 
Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698