Updating the Chromoting Test Driver to target the test environment

Updating the Chromoting Test Driver to target the test environment

This change updated several of the Chromoting Test Driver classes to use
URLs and settings which are needed to retrieve and connect to hosts
running in our test environment.

There are also two changes (null check and initializing the FeatureList)
which are needed for the tool to run (external dependencies changed but
the tool hasn't been updated yet).

BUG=N/A

Committed: https://crrev.com/910989df740db415b1ac009378f54dc257a45e10
Cr-Commit-Position: refs/heads/master@{#436020}

[joedow, 2016-12-02 02:24:32]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 02:25:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-12-02 02:46:01]

joedow@chromium.org changed reviewers:
+ sergeyu@chromium.org

[joedow, 2016-12-02 02:46:01]

PTAL!

[commit-bot: I haz the power, 2016-12-02 02:52:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 02:52:47]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-12-02 16:18:19]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 16:18:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 16:47:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 16:47:55]

Dry run: This issue passed the CQ dry run.

[Sergey Ulanov, 2016-12-02 19:55:44]

https://codereview.chromium.org/2542343004/diff/20001/remoting/client/chromot...
File remoting/client/chromoting_client.cc (right):

https://codereview.chromium.org/2542343004/diff/20001/remoting/client/chromot...
remoting/client/chromoting_client.cc:90: if (audio_consumer_) {
nit: Please move protocol_config_->DisableAudioChannel(); call above (line 71)
here.

https://codereview.chromium.org/2542343004/diff/20001/remoting/test/chromotin...
File remoting/test/chromoting_test_driver_environment.h (right):

https://codereview.chromium.org/2542343004/diff/20001/remoting/test/chromotin...
remoting/test/chromoting_test_driver_environment.h:131: bool
use_test_environment_;
make it const, to ensure it's initialized in the constructor.

[joedow, 2016-12-02 20:09:47]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 20:10:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-12-02 20:10:43]

Updated based on feedback, PTAL!

[commit-bot: I haz the power, 2016-12-02 20:40:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 20:40:38]

Dry run: This issue passed the CQ dry run.

[Sergey Ulanov, 2016-12-02 20:53:08]

LGTM

[joedow, 2016-12-02 21:07:45]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-12-02 21:08:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 21:15:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480712865827160,
"parent_rev": "df972b6d99f318c59fa7ccea495611e0e54a639e", "commit_rev":
"2138d14d3cfcc682d389b63481be203fada57d4f"}

[commit-bot: I haz the power, 2016-12-02 21:16:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-02 21:19:21]

Description was changed from

==========
Updating the Chromoting Test Driver to target the test environment

This change updated several of the Chromoting Test Driver classes to use
URLs and settings which are needed to retrieve and connect to hosts
running in our test environment.

There are also two changes (null check and initializing the FeatureList)
which are needed for the tool to run (external dependencies changed but
the tool hasn't been updated yet).

BUG=N/A
==========

to

==========
Updating the Chromoting Test Driver to target the test environment

This change updated several of the Chromoting Test Driver classes to use
URLs and settings which are needed to retrieve and connect to hosts
running in our test environment.

There are also two changes (null check and initializing the FeatureList)
which are needed for the tool to run (external dependencies changed but
the tool hasn't been updated yet).

BUG=N/A

Committed: https://crrev.com/910989df740db415b1ac009378f54dc257a45e10
Cr-Commit-Position: refs/heads/master@{#436020}
==========

[commit-bot: I haz the power, 2016-12-02 21:19:22]

Patchset 3 (id:??) landed as
https://crrev.com/910989df740db415b1ac009378f54dc257a45e10
Cr-Commit-Position: refs/heads/master@{#436020}