(Reland) Insert logcat as part of test result for android instrumentation tests.

(Reland) Insert logcat as part of test result for android instrumentation tests.

In this cl, we are trying to add the logcat of each instrumentation
test into the corresponding test result object, so that when we are
checking the result of each test case, we would be able to see the
corresponding logcat for that test case at the same time.

BUG=631213
Committed: https://crrev.com/af7d1b8ebb52ace8f7443689abf4e79cd117ef9d
Cr-Commit-Position: refs/heads/master@{#435802}

[BigBossZhiling, 2016-12-01 23:00:22]

Description was changed from

==========
(Reland) Insert logcat as part of test result for android instrumentation tests.

In this cl, we are trying to add the logcat of each instrumentation
test into the corresponding test result object, so that when we are
checking the result of each test case, we would be able to see the
corresponding logcat for that test case at the same time.

BUG=631213
==========

to

==========
(Reland) Insert logcat as part of test result for android instrumentation tests.

In this cl, we are trying to add the logcat of each instrumentation
test into the corresponding test result object, so that when we are
checking the result of each test case, we would be able to see the
corresponding logcat for that test case at the same time.

BUG=631213
==========

[BigBossZhiling, 2016-12-01 23:00:22]

hzl@google.com changed reviewers:
+ jbudorick@chromium.org

[BigBossZhiling, 2016-12-01 23:00:47]

W: 35,11: Catching too general exception Exception (broad-except)
W: 59,11: Catching too general exception Exception (broad-except)

Is there anyway to stop these two warnings?

[mikecase (-- gone --), 2016-12-01 23:06:16]

On 2016/12/01 at 23:00:47, hzl wrote:
> W: 35,11: Catching too general exception Exception (broad-except)
> W: 59,11: Catching too general exception Exception (broad-except)
> 
> Is there anyway to stop these two warnings?

Example of disabling that...

https://cs.chromium.org/chromium/src/build/android/gyp/lint.py?q=pylint+file:...

[BigBossZhiling, 2016-12-01 23:21:43]

avoided logic to avoid duplicate stream_name (which will cause the stream to
crash)

[BigBossZhiling, 2016-12-01 23:22:05]

added*

[jbudorick, 2016-12-01 23:42:11]

https://codereview.chromium.org/2542333002/diff/60001/build/android/pylib/loc...
File build/android/pylib/local/device/local_device_instrumentation_test_run.py
(right):

https://codereview.chromium.org/2542333002/diff/60001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:252:
stream_name = 'logcat_%s_%s' % (
Mentioned offline: include the device serial in the stream name, too.

[BigBossZhiling, 2016-12-01 23:53:59]

added serial number in stream name

https://codereview.chromium.org/2542333002/diff/60001/build/android/pylib/loc...
File build/android/pylib/local/device/local_device_instrumentation_test_run.py
(right):

https://codereview.chromium.org/2542333002/diff/60001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_instrumentation_test_run.py:252:
stream_name = 'logcat_%s_%s' % (
On 2016/12/01 23:42:11, jbudorick wrote:
> Mentioned offline: include the device serial in the stream name, too.

Done.

[jbudorick, 2016-12-01 23:55:11]

lgtm

[BigBossZhiling, 2016-12-02 00:00:02]

The CQ bit was checked by hzl@google.com

[commit-bot: I haz the power, 2016-12-02 00:01:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 01:11:30]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480636802927070,
"parent_rev": "f3904bd3f4bd740220f43134a560ee96e01f86df", "commit_rev":
"879b6da6ae0c69687ef2f2375f296e0ab4dcc887"}

[commit-bot: I haz the power, 2016-12-02 01:12:38]

Description was changed from

==========
(Reland) Insert logcat as part of test result for android instrumentation tests.

In this cl, we are trying to add the logcat of each instrumentation
test into the corresponding test result object, so that when we are
checking the result of each test case, we would be able to see the
corresponding logcat for that test case at the same time.

BUG=631213
==========

to

==========
(Reland) Insert logcat as part of test result for android instrumentation tests.

In this cl, we are trying to add the logcat of each instrumentation
test into the corresponding test result object, so that when we are
checking the result of each test case, we would be able to see the
corresponding logcat for that test case at the same time.

BUG=631213
==========

[commit-bot: I haz the power, 2016-12-02 01:12:39]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-02 01:14:36]

Description was changed from

==========
(Reland) Insert logcat as part of test result for android instrumentation tests.

In this cl, we are trying to add the logcat of each instrumentation
test into the corresponding test result object, so that when we are
checking the result of each test case, we would be able to see the
corresponding logcat for that test case at the same time.

BUG=631213
==========

to

==========
(Reland) Insert logcat as part of test result for android instrumentation tests.

In this cl, we are trying to add the logcat of each instrumentation
test into the corresponding test result object, so that when we are
checking the result of each test case, we would be able to see the
corresponding logcat for that test case at the same time.

BUG=631213

Committed: https://crrev.com/af7d1b8ebb52ace8f7443689abf4e79cd117ef9d
Cr-Commit-Position: refs/heads/master@{#435802}
==========

[commit-bot: I haz the power, 2016-12-02 01:14:37]

Patchset 5 (id:??) landed as
https://crrev.com/af7d1b8ebb52ace8f7443689abf4e79cd117ef9d
Cr-Commit-Position: refs/heads/master@{#435802}