|
|
Chromium Code Reviews|
Created:
4 years ago by Eugene But (OOO till 7-30) Modified:
4 years ago Reviewers:
kkhorimoto CC:
chromium-reviews, mac-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDo not inject windowID into non-HTML documents.
Injection windowID to PDF returns JSException error and DCHECKs.
BUG=None
Committed: https://crrev.com/6a129229461933b9439a152641d2b6740ea5c824
Cr-Commit-Position: refs/heads/master@{#436379}
Patch Set 1 #Patch Set 2 : Fixed unit tests #Messages
Total messages: 20 (10 generated)
eugenebut@chromium.org changed reviewers: + kkhorimoto@chromium.org
lgtm
Thanks for quick review!
The CQ bit was checked by eugenebut@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL I fixed unit tests
lgtm
The CQ bit was checked by eugenebut@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480967463974670,
"parent_rev": "75f39a93c93db386d0c0fe3a66cb7e9bf3aeefa5", "commit_rev":
"fd0e7151c94687b81b52090497e35dce4f0ab341"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Do not inject windowID into non-HTML documents. Injection windowID to PDF returns JSException error and DCHECKs. BUG=None ========== to ========== Do not inject windowID into non-HTML documents. Injection windowID to PDF returns JSException error and DCHECKs. BUG=None Committed: https://crrev.com/6a129229461933b9439a152641d2b6740ea5c824 Cr-Commit-Position: refs/heads/master@{#436379} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6a129229461933b9439a152641d2b6740ea5c824 Cr-Commit-Position: refs/heads/master@{#436379} |
