Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2542303002: Do not inject windowID into non-HTML documents. (Closed)

Created:
4 years ago by Eugene But (OOO till 7-30)
Modified:
4 years ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not inject windowID into non-HTML documents. Injection windowID to PDF returns JSException error and DCHECKs. BUG=None Committed: https://crrev.com/6a129229461933b9439a152641d2b6740ea5c824 Cr-Commit-Position: refs/heads/master@{#436379}

Patch Set 1 #

Patch Set 2 : Fixed unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
Eugene But (OOO till 7-30)
4 years ago (2016-12-01 21:54:08 UTC) #2
kkhorimoto
lgtm
4 years ago (2016-12-01 22:11:41 UTC) #3
Eugene But (OOO till 7-30)
Thanks for quick review!
4 years ago (2016-12-01 22:12:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542303002/1
4 years ago (2016-12-01 22:13:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/116756)
4 years ago (2016-12-01 23:05:00 UTC) #8
Eugene But (OOO till 7-30)
PTAL I fixed unit tests
4 years ago (2016-12-03 01:21:23 UTC) #13
kkhorimoto
lgtm
4 years ago (2016-12-05 19:46:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542303002/20001
4 years ago (2016-12-05 19:51:34 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 20:05:03 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-05 20:06:45 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6a129229461933b9439a152641d2b6740ea5c824
Cr-Commit-Position: refs/heads/master@{#436379}

Powered by Google App Engine
This is Rietveld 408576698