Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 2542263003: Remove apt_config_val from apt.include (Closed)

Created:
4 years ago by Tom (Use chromium acct)
Modified:
4 years ago
Reviewers:
Michael Moss
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, Michael Moss, wfh+watch_chromium.org, Lei Zhang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove apt_config_val from apt.include find_apt_sources() used to dump all variables in apt-config and grep for the needed variables. However, apt-config provides a 'shell' arg for this purpose, so we use that instead. Also remove the unused APT_SOURCES variable. BUG=663069 R=mmoss@chromium.org Committed: https://crrev.com/902df7e81d1c9f04e1500dd0bce59647b08d6b85 Cr-Commit-Position: refs/heads/master@{#435763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M chrome/installer/linux/common/apt.include View 2 chunks +1 line, -16 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Tom (Use chromium acct)
4 years ago (2016-12-01 22:37:50 UTC) #2
Michael Moss
LGTM. Thanks, I totally forgot to go back and update this after I did the ...
4 years ago (2016-12-01 23:34:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542263003/1
4 years ago (2016-12-01 23:35:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 23:41:41 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-01 23:44:38 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/902df7e81d1c9f04e1500dd0bce59647b08d6b85
Cr-Commit-Position: refs/heads/master@{#435763}

Powered by Google App Engine
This is Rietveld 408576698