Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1559)

Issue 2542253004: Instant Apps: Don't navigate to ephemeral resolver by default. (Closed)

Created:
4 years ago by Maria
Modified:
4 years ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instant Apps: Don't navigate to ephemeral resolver by default. Remove @RetryOnFailure annotations from ExternalNavigationDelegateImplTest since the flakiness dashboard shows they are not flaking. BUG=669304 Committed: https://crrev.com/b70df43d0a4e875f0690a0c6ab1499d7c1acb751 Cr-Commit-Position: refs/heads/master@{#436673}

Patch Set 1 #

Patch Set 2 : Fix a bug for ResolveInfo entries without activityInfo field. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java View 1 2 chunks +14 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java View 8 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Maria
4 years ago (2016-12-03 00:52:26 UTC) #2
Ted C
lgtm
4 years ago (2016-12-03 00:58:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542253004/1
4 years ago (2016-12-05 19:35:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/192775)
4 years ago (2016-12-05 21:33:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542253004/20001
4 years ago (2016-12-06 00:21:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/79899)
4 years ago (2016-12-06 01:46:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542253004/20001
4 years ago (2016-12-06 18:28:00 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 19:06:33 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-06 19:09:46 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b70df43d0a4e875f0690a0c6ab1499d7c1acb751
Cr-Commit-Position: refs/heads/master@{#436673}

Powered by Google App Engine
This is Rietveld 408576698