Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2542253003: Fix unintended spec change: Final fields not being initialized is only a warning. (Closed)

Created:
4 years ago by Lasse Reichstein Nielsen
Modified:
4 years ago
Reviewers:
eernst
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix unintended spec change: Final fields not being initialized is only a warning. A recent spec change made it an error, but the existing spec didn't actually say that - it's one of the few warnings that do not correspond to e runtime error. R=eernst@google.com Committed: https://github.com/dart-lang/sdk/commit/81f8ea0a0a7ec92306a3d5b29d888ab0adbf33ad

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M docs/language/dartLangSpec.tex View 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
4 years ago (2016-12-02 11:54:47 UTC) #2
eernst
lgtm https://codereview.chromium.org/2542253003/diff/1/docs/language/dartLangSpec.tex File docs/language/dartLangSpec.tex (right): https://codereview.chromium.org/2542253003/diff/1/docs/language/dartLangSpec.tex#newcode1393 docs/language/dartLangSpec.tex:1393: all such variables are initialized with the \NULL{} ...
4 years ago (2016-12-02 14:09:46 UTC) #3
Lasse Reichstein Nielsen
4 years ago (2016-12-05 09:48:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
81f8ea0a0a7ec92306a3d5b29d888ab0adbf33ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698