Add hovering feature to AshDevToolsDOMAgent

ash/common/devtools/ash_devtools_dom_agent.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_DOM_AGENT_H_
 #define ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_DOM_AGENT_H_
 
 #include "ash/common/wm_shell.h"
 #include "ash/common/wm_window_observer.h"
 #include "base/compiler_specific.h"
@@ skipping 17 matching lines @@
 };
 
 class ASH_EXPORT AshDevToolsDOMAgent
     : public NON_EXPORTED_BASE(ui::devtools::UiDevToolsBaseAgent<
                                ui::devtools::protocol::DOM::Metainfo>),
       public WmWindowObserver,
       public views::WidgetObserver,
       public views::WidgetRemovalsObserver,
       public views::ViewObserver {
  public:
-  explicit AshDevToolsDOMAgent(ash::WmShell* shell);
+  explicit AshDevToolsDOMAgent(

[sadrul, 2016/12/06 20:48:59]

You don't need explicit anymore.

[Sarmad Hashmi, 2016/12/06 22:54:34]

Done.

+      ash::WmShell* shell,
+      scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner);
   ~AshDevToolsDOMAgent() override;
 
   // DOM::Backend
   ui::devtools::protocol::Response disable() override;
   ui::devtools::protocol::Response getDocument(
       std::unique_ptr<ui::devtools::protocol::DOM::Node>* out_root) override;
+  ui::devtools::protocol::Response highlightNode(
+      std::unique_ptr<ui::devtools::protocol::DOM::HighlightConfig>
+          highlight_config,
+      ui::devtools::protocol::Maybe<int> node_id) override;
+  ui::devtools::protocol::Response hideHighlight() override;
 
   // WindowObserver
   void OnWindowTreeChanging(WmWindow* window,
                             const TreeChangeParams& params) override;
   void OnWindowTreeChanged(WmWindow* window,
                            const TreeChangeParams& params) override;
   void OnWindowStackingChanged(WmWindow* window) override;
   void OnWindowBoundsChanged(WmWindow* window,
                              const gfx::Rect& old_bounds,
                              const gfx::Rect& new_bounds) override;
@@ skipping 45 matching lines @@
   void RemoveWidgetNode(views::Widget* widget, bool remove_observer);
 
   void AddViewTree(views::View* view);
   void RemoveViewTree(views::View* view,
                       views::View* parent,
                       bool remove_observer);
   void RemoveViewNode(views::View* view,
                       views::View* parent,
                       bool remove_observer);
 
+  void DestroyHighlightingWidget();
   void RemoveObservers();
   void Reset();
 
+  using WindowAndBoundsPair = std::pair<WmWindow*, gfx::Rect>;
+  WindowAndBoundsPair GetNodeWindowAndBounds(int node_id);
+  void InitializeHighlightingWidget();
+  void UpdateHighlight(std::pair<WmWindow*, gfx::Rect>,

[sadrul, 2016/12/06 20:48:59]

const WindowAndBoundsPair&

[Sarmad Hashmi, 2016/12/06 22:54:34]

Done.

+                       SkColor background,
+                       SkColor border);
+  void HighlightNode(
+      std::unique_ptr<ui::devtools::protocol::DOM::HighlightConfig>
+          highlight_config,
+      int node_id);
+  bool IsHighlightingWindow(WmWindow* window);
+
+  std::unique_ptr<views::Widget> widget_for_highlighting_;
+  scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner_;
   ash::WmShell* shell_;
 
   using WindowToNodeIdMap = std::unordered_map<WmWindow*, int>;
   WindowToNodeIdMap window_to_node_id_map_;
   using NodeIdToWindowMap = std::unordered_map<int, WmWindow*>;
   NodeIdToWindowMap node_id_to_window_map_;
 
   using WidgetToNodeIdMap = std::unordered_map<views::Widget*, int>;
   WidgetToNodeIdMap widget_to_node_id_map_;
   using NodeIdToWidgetMap = std::unordered_map<int, views::Widget*>;
   NodeIdToWidgetMap node_id_to_widget_map_;
 
   using ViewToNodeIdMap = std::unordered_map<views::View*, int>;
   ViewToNodeIdMap view_to_node_id_map_;
   using NodeIdToViewMap = std::unordered_map<int, views::View*>;
   NodeIdToViewMap node_id_to_view_map_;
 
   base::ObserverList<AshDevToolsDOMAgentObserver> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(AshDevToolsDOMAgent);
 };
 
 }  // namespace devtools
 }  // namespace ash
 
 #endif  // ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_DOM_AGENT_H_