Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 25422003: Ignore unsupported disposal methods when decoding GIF (Closed)

Created:
7 years, 2 months ago by Xianzhu
Modified:
7 years, 2 months ago
CC:
blink-reviews, jeez, hclam_chromium.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Ignore unsupported disposal methods when decoding GIF Avoid assertion failures about invalid disposal methods by ignoring unsupported values when decoding GIF. The bug is caused by some GIF images containing frames with disposal method 5. Don't know what the author wanted. BUG=302034 R=aelias@chromium.org, pkasting@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158769

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M Source/core/platform/image-decoders/gif/GIFImageDecoderTest.cpp View 1 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/platform/image-decoders/gif/GIFImageReader.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
A + Source/web/tests/data/invalid-disposal-method.gif View 1 Binary file 0 comments Download

Messages

Total messages: 10 (0 generated)
Xianzhu
Perhaps it'd be better to print some warning messages, but I'm ignoring the unsupported values ...
7 years, 2 months ago (2013-10-01 03:37:41 UTC) #1
Peter Kasting
PLease add a test for this. LGTM once that's done.
7 years, 2 months ago (2013-10-01 20:55:04 UTC) #2
Xianzhu
On 2013/10/01 20:55:04, Peter Kasting wrote: > PLease add a test for this. Done.
7 years, 2 months ago (2013-10-02 23:48:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/25422003/5001
7 years, 2 months ago (2013-10-02 23:51:18 UTC) #4
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=7965
7 years, 2 months ago (2013-10-03 00:08:03 UTC) #5
Xianzhu
+aelias as OWNER of Source/web/tests/data
7 years, 2 months ago (2013-10-03 00:13:14 UTC) #6
aelias_OOO_until_Jul13
lgtm
7 years, 2 months ago (2013-10-03 00:19:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/25422003/5001
7 years, 2 months ago (2013-10-03 00:20:22 UTC) #8
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=7970
7 years, 2 months ago (2013-10-03 00:40:51 UTC) #9
Xianzhu
7 years, 2 months ago (2013-10-03 01:03:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r158769 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698