nss.gyp - Issue 254213002: Fix bugs in intel-gcm-x86-masm.asm and re-enable the Intel AES assembly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: nss.gyp

Issue 254213002: Fix bugs in intel-gcm-x86-masm.asm and re-enable the Intel AES assembly (Closed) Base URL: http://src.chromium.org/svn/trunk/deps/third_party/nss

Patch Set: Update to Shay's fix. Remove an unnecessary loop in intel-gcm-x64-masm.asm Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: nss.gyp

diff --git a/nss.gyp b/nss.gyp

index d3be663701ad3760f1c10aef876e5b06b1aa5023..d02d6f7633e575a1e80cb4aa49afd436e45c9298 100644

--- a/nss.gyp

+++ b/nss.gyp

@@ -1171,13 +1171,7 @@

'MP_ASSEMBLY_DIV_2DX1D',

'MP_USE_UINT_DIGIT',

'MP_NO_MP_WORD',

- ],

- # intel-gcm-x86-masm.asm seems to corrupt memory, so disable all

- # Intel AES assembly code. (http://crbug.com/367515)

- 'sources!': [

- 'nss/lib/freebl/intel-aes-x86-masm.asm',

- 'nss/lib/freebl/intel-gcm-wrap.c',

- 'nss/lib/freebl/intel-gcm-x86-masm.asm',

+ 'USE_HW_AES',

'msvs_settings': {

'MASM': {

« no previous file with comments | « no previous file | nss/lib/freebl/intel-gcm-x64-masm.asm » ('j') | nss/lib/freebl/intel-gcm-x86-masm.asm » ('J')