Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: blimp/client/core/settings/BUILD.gn

Issue 2542083004: Make //blimp/client/app a real embedder of //blimp/client/public (Closed)
Patch Set: Fix findbugs issue Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/core/session/BUILD.gn ('k') | blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/core/settings/BUILD.gn
diff --git a/blimp/client/core/settings/BUILD.gn b/blimp/client/core/settings/BUILD.gn
index 61ee24030fe3c93f9aefefdff153598686581d38..4e40031bba7934c11c109349f6af5d7c47d7637c 100644
--- a/blimp/client/core/settings/BUILD.gn
+++ b/blimp/client/core/settings/BUILD.gn
@@ -9,8 +9,8 @@ if (is_android) {
source_set("settings") {
visibility = [
- "//blimp/client/app:*", # TODO(nyquist): Remove this. See crbug/651964.
"//blimp/client/core/*",
+ "//blimp/engine:browser_tests",
]
sources = [
@@ -78,7 +78,7 @@ source_set("unit_tests") {
if (is_android) {
android_library("settings_java") {
visibility = [
- "//blimp/client/app:*", # TODO(nyquist): Remove this. See crbug/651964.
+ "//blimp/client/app:blimp_test_java_core_deps",
"//blimp/client/core/*",
]
« no previous file with comments | « blimp/client/core/session/BUILD.gn ('k') | blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698