blimp/client/core/contents/BUILD.gn - Issue 2542083004: Make //blimp/client/app a real embedder of //blimp/client/public

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/BUILD.gn

Issue 2542083004: Make //blimp/client/app a real embedder of //blimp/client/public (Closed)

Patch Set: Fix findbugs issue Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/contents/BUILD.gn

diff --git a/blimp/client/core/contents/BUILD.gn b/blimp/client/core/contents/BUILD.gn

index da360d3f33e119afa9a40630af7edb3898477acc..270ba7055df45bdafe75e16bd6e41029e2d06846 100644

--- a/blimp/client/core/contents/BUILD.gn

+++ b/blimp/client/core/contents/BUILD.gn

@@ -9,8 +9,8 @@ if (is_android) {

source_set("contents") {

visibility = [

- "//blimp/client/app:*", # TODO(nyquist): Remove this. See crbug/651964.

"//blimp/client/core/*",

+ "//blimp/engine:browser_tests",

]

sources = [

@@ -153,7 +153,7 @@ source_set("unit_tests") {

if (is_android) {

android_library("contents_java") {

visibility = [

- "//blimp/client/app:*", # TODO(nyquist): Remove this. See crbug/651964.

+ "//blimp/client/app:blimp_test_java_core_deps",

"//blimp/client/core/*",

]